diff mbox series

[49/78] media: i2c: ov7740: use pm_runtime_resume_and_get()

Message ID	ec7514ee656a623807aab03b6b70f473c6c884c8.1619191723.git.mchehab+huawei@kernel.org
State	New
Headers	show Return-Path: <linux-media-owner@kernel.org> From: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> Cc: linuxarm@huawei.com, mauro.chehab@huawei.com, Mauro Carvalho Chehab <mchehab+huawei@kernel.org>, Mauro Carvalho Chehab <mchehab@kernel.org>, Wenyou Yang <wenyou.yang@microchip.com>, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: [PATCH 49/78] media: i2c: ov7740: use pm_runtime_resume_and_get() Date: Sat, 24 Apr 2021 08:44:59 +0200 Message-Id: <ec7514ee656a623807aab03b6b70f473c6c884c8.1619191723.git.mchehab+huawei@kernel.org> In-Reply-To: <cover.1619191723.git.mchehab+huawei@kernel.org> References: <cover.1619191723.git.mchehab+huawei@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: Mauro Carvalho Chehab <mchehab@kernel.org> To: unlisted-recipients:; (no To-header on input) Precedence: bulk
Series	[01/78] media: atmel: properly get pm_runtime \| expand [01/78] media: atmel: properly get pm_runtime [04/78] media: rcar_fdp1: fix pm_runtime_get_sync() usage count [05/78] media: mdk-mdp: fix pm_runtime_get_sync() usage count [06/78] media: renesas-ceu: fix pm_runtime_get_sync() usage count [09/78] media: sh_vou: fix pm_runtime_get_sync() usage count [10/78] media: sti/hva: use pm_runtime_resume_and_get() [12/78] staging: media: atomisp_fops: use pm_runtime_resume_and_get() [15/78] staging: media: ipu3: use pm_runtime_resume_and_get() [18/78] staging: media: csi: use pm_runtime_resume_and_get() [20/78] media: mtk-vcodec: fix pm_runtime_get_sync() usage count [23/78] media: sun8i_rotate: fix pm_runtime_get_sync() usage count [26/78] media: i2c: dw9714: use pm_runtime_resume_and_get() [27/78] media: i2c: dw9768: use pm_runtime_resume_and_get() [29/78] media: i2c: hi556: use pm_runtime_resume_and_get() [30/78] media: i2c: imx214: use pm_runtime_resume_and_get() [33/78] media: i2c: imx274: use pm_runtime_resume_and_get() [34/78] media: i2c: imx290: use pm_runtime_resume_and_get() [39/78] media: i2c: ov02a10: use pm_runtime_resume_and_get() [41/78] media: i2c: ov2659: use pm_runtime_resume_and_get() [42/78] media: i2c: ov2685: use pm_runtime_resume_and_get() [43/78] media: i2c: ov2740: use pm_runtime_resume_and_get() [44/78] media: i2c: ov5647: use pm_runtime_resume_and_get() [49/78] media: i2c: ov7740: use pm_runtime_resume_and_get() [50/78] media: i2c: ov8856: use pm_runtime_resume_and_get() [56/78] media: coda: use pm_runtime_resume_and_get() [57/78] media: exynos4-is: use pm_runtime_resume_and_get() [59/78] media: mtk-jpeg: use pm_runtime_resume_and_get() [60/78] media: camss-csid: use pm_runtime_resume_and_get() [61/78] media: camss-csiphy: use pm_runtime_resume_and_get() [62/78] media: camss-ispif: use pm_runtime_resume_and_get() [63/78] media: camss-vfe: use pm_runtime_resume_and_get() [64/78] media: core: use pm_runtime_resume_and_get() [68/78] media: rcar-fcp: use pm_runtime_resume_and_get() [70/78] media: rga-buf: use pm_runtime_resume_and_get() [71/78] media: rkisp1-capture: use pm_runtime_resume_and_get() [72/78] media: s3c-camif: use pm_runtime_resume_and_get() [75/78] media: stm32: use pm_runtime_resume_and_get() [77/78] media: ti-vpe: use pm_runtime_resume_and_get() [78/78] media: vsp1: use pm_runtime_resume_and_get()

Commit Message

Mauro Carvalho Chehab April 24, 2021, 6:44 a.m. UTC

Commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter")
added pm_runtime_resume_and_get() in order to automatically handle
dev->power.usage_count decrement on errors.

Use the new API, in order to cleanup the error check logic.

Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
---
 drivers/media/i2c/ov7740.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff mbox series

Patch

diff --git a/drivers/media/i2c/ov7740.c b/drivers/media/i2c/ov7740.c
index 47a9003d29d6..849a1ce61cf7 100644
--- a/drivers/media/i2c/ov7740.c
+++ b/drivers/media/i2c/ov7740.c
@@ -624,11 +624,9 @@  static int ov7740_set_stream(struct v4l2_subdev *sd, int enable)
 	}
 
 	if (enable) {
-		ret = pm_runtime_get_sync(&client->dev);
-		if (ret < 0) {
-			pm_runtime_put_noidle(&client->dev);
+		ret = pm_runtime_resume_and_get(&client->dev);
+		if (ret < 0)
 			goto err_unlock;
-		}
 
 		ret = ov7740_start_streaming(ov7740);
 		if (ret)
@@ -1165,7 +1163,7 @@  static int ov7740_remove(struct i2c_client *client)
 	v4l2_async_unregister_subdev(sd);
 	ov7740_free_controls(ov7740);
 
-	pm_runtime_get_sync(&client->dev);
+	pm_runtime_resume_and_get(&client->dev);
 	pm_runtime_disable(&client->dev);
 	pm_runtime_set_suspended(&client->dev);
 	pm_runtime_put_noidle(&client->dev);