diff mbox series

[V2] ARM: dts: imx6q-dhcom: Add PU,VDD1P1,VDD2P5 regulators

Message ID 20210423175701.76637-1-marex@denx.de
State New
Headers show
Series [V2] ARM: dts: imx6q-dhcom: Add PU,VDD1P1,VDD2P5 regulators | expand

Commit Message

Marek Vasut April 23, 2021, 5:57 p.m. UTC 
Per schematic, both PU and SOC regulator are supplied from LTC3676 SW1
via VDDSOC_IN rail, add the PU input. Both VDD1P1, VDD2P5 are supplied
from LTC3676 SW2 via VDDHIGH_IN rail, add both inputs.

While no instability or problems are currently observed, the regulators
should be fully described in DT and that description should fully match
the hardware, else this might lead to unforseen issues later. Fix this.

Fixes: 52c7a088badd ("ARM: dts: imx6q: Add support for the DHCOM iMX6 SoM and PDK2")
Cc: Christoph Niedermaier <cniedermaier@dh-electronics.com>
Cc: Fabio Estevam <festevam@gmail.com>
Cc: Ludwig Zenz <lzenz@dh-electronics.com>
Cc: NXP Linux Team <linux-imx@nxp.com>
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: stable@vger.kernel.org
---
V2: Amend commit message
---
 arch/arm/boot/dts/imx6q-dhcom-som.dtsi | 12 ++++++++++++
 1 file changed, 12 insertions(+)

Comments

Fabio Estevam April 26, 2021, 1:07 a.m. UTC | #1 
Hi Marek,

On Fri, Apr 23, 2021 at 2:57 PM Marek Vasut <marex@denx.de> wrote:
>

> Per schematic, both PU and SOC regulator are supplied from LTC3676 SW1

> via VDDSOC_IN rail, add the PU input. Both VDD1P1, VDD2P5 are supplied

> from LTC3676 SW2 via VDDHIGH_IN rail, add both inputs.

>

> While no instability or problems are currently observed, the regulators

> should be fully described in DT and that description should fully match

> the hardware, else this might lead to unforseen issues later. Fix this.

>

> Fixes: 52c7a088badd ("ARM: dts: imx6q: Add support for the DHCOM iMX6 SoM and PDK2")

> Cc: Christoph Niedermaier <cniedermaier@dh-electronics.com>

> Cc: Fabio Estevam <festevam@gmail.com>

> Cc: Ludwig Zenz <lzenz@dh-electronics.com>

> Cc: NXP Linux Team <linux-imx@nxp.com>

> Cc: Shawn Guo <shawnguo@kernel.org>

> Cc: stable@vger.kernel.org


You missed your Signed-off-by tag.

With that added:

Reviewed-by: Fabio Estevam <festevam@gmail.com>
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/imx6q-dhcom-som.dtsi b/arch/arm/boot/dts/imx6q-dhcom-som.dtsi
index 236fc205c389..d0768ae429fa 100644
--- a/arch/arm/boot/dts/imx6q-dhcom-som.dtsi
+++ b/arch/arm/boot/dts/imx6q-dhcom-som.dtsi
@@ -406,6 +406,18 @@  &reg_soc {
 	vin-supply = <&sw1_reg>;
 };
 
+&reg_pu {
+	vin-supply = <&sw1_reg>;
+};
+
+&reg_vdd1p1 {
+	vin-supply = <&sw2_reg>;
+};
+
+&reg_vdd2p5 {
+	vin-supply = <&sw2_reg>;
+};
+
 &uart1 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_uart1>;