| Message ID | 20210423084750.18533-1-jon.lin@rock-chips.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v1,1/8] dt-bindings: spi: spi-rockchip: add description for rv1126 | expand |
On Fri, Apr 23, 2021 at 04:47:48PM +0800, Jon Lin wrote: > The error here is to calculate the width as 8 bits. In fact, 16 bits > should be considered. Bugfix patches like this should go at the start of a series so they can be sent as fixes without any dependencies on earlier patches.
diff --git a/drivers/spi/spi-rockchip.c b/drivers/spi/spi-rockchip.c index cfcbfd6c1be5..c245af1692c7 100644 --- a/drivers/spi/spi-rockchip.c +++ b/drivers/spi/spi-rockchip.c @@ -547,8 +547,8 @@ static int rockchip_spi_config(struct rockchip_spi *rs, * interrupt exactly when the fifo is full doesn't seem to work, * so we need the strict inequality here */ - if (xfer->len < rs->fifo_len) - writel_relaxed(xfer->len - 1, rs->regs + ROCKCHIP_SPI_RXFTLR); + if ((xfer->len / rs->n_bytes) < rs->fifo_len) + writel_relaxed(xfer->len / rs->n_bytes - 1, rs->regs + ROCKCHIP_SPI_RXFTLR); else writel_relaxed(rs->fifo_len / 2 - 1, rs->regs + ROCKCHIP_SPI_RXFTLR);
The error here is to calculate the width as 8 bits. In fact, 16 bits should be considered. Signed-off-by: Jon Lin <jon.lin@rock-chips.com> --- drivers/spi/spi-rockchip.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)