diff mbox series

[v2,1/3] dt-bindings: serial: Normalize the node name of the serial port

Message ID 20210422085837.513-2-thunder.leizhen@huawei.com
State New
Headers show
Series dt-bindings: serial: pl011: Fix some dtbs_check warnings | expand

Commit Message

Leizhen (ThunderTown) April 22, 2021, 8:58 a.m. UTC
Only letters, digits, and commas that describe the base address of the
serial port in hexadecimal format are allowed.

Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
---
 Documentation/devicetree/bindings/serial/serial.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Rob Herring (Arm) April 30, 2021, 3:18 p.m. UTC | #1
On Thu, Apr 22, 2021 at 04:58:35PM +0800, Zhen Lei wrote:
> Only letters, digits, and commas that describe the base address of the

> serial port in hexadecimal format are allowed.

> 

> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>

> ---

>  Documentation/devicetree/bindings/serial/serial.yaml | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

> 

> diff --git a/Documentation/devicetree/bindings/serial/serial.yaml b/Documentation/devicetree/bindings/serial/serial.yaml

> index 65e75d040521..71aec7fda07d 100644

> --- a/Documentation/devicetree/bindings/serial/serial.yaml

> +++ b/Documentation/devicetree/bindings/serial/serial.yaml

> @@ -21,7 +21,7 @@ description:

>  

>  properties:

>    $nodename:

> -    pattern: "^serial(@.*)?$"

> +    pattern: "^serial(@[0-9a-f,]+)?$"


The format of unit-addresses is dictated by the bus (parent), so this is 
the wrong place to enforce this. 

Rob
Leizhen (ThunderTown) May 6, 2021, 2:08 a.m. UTC | #2
On 2021/4/30 23:18, Rob Herring wrote:
> On Thu, Apr 22, 2021 at 04:58:35PM +0800, Zhen Lei wrote:

>> Only letters, digits, and commas that describe the base address of the

>> serial port in hexadecimal format are allowed.

>>

>> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>

>> ---

>>  Documentation/devicetree/bindings/serial/serial.yaml | 2 +-

>>  1 file changed, 1 insertion(+), 1 deletion(-)

>>

>> diff --git a/Documentation/devicetree/bindings/serial/serial.yaml b/Documentation/devicetree/bindings/serial/serial.yaml

>> index 65e75d040521..71aec7fda07d 100644

>> --- a/Documentation/devicetree/bindings/serial/serial.yaml

>> +++ b/Documentation/devicetree/bindings/serial/serial.yaml

>> @@ -21,7 +21,7 @@ description:

>>  

>>  properties:

>>    $nodename:

>> -    pattern: "^serial(@.*)?$"

>> +    pattern: "^serial(@[0-9a-f,]+)?$"

> 

> The format of unit-addresses is dictated by the bus (parent), so this is 

> the wrong place to enforce this. 


Okay, so I'll leave this place unchanged.

> 

> Rob

> 

> .

>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/serial/serial.yaml b/Documentation/devicetree/bindings/serial/serial.yaml
index 65e75d040521..71aec7fda07d 100644
--- a/Documentation/devicetree/bindings/serial/serial.yaml
+++ b/Documentation/devicetree/bindings/serial/serial.yaml
@@ -21,7 +21,7 @@  description:
 
 properties:
   $nodename:
-    pattern: "^serial(@.*)?$"
+    pattern: "^serial(@[0-9a-f,]+)?$"
 
   cts-gpios:
     maxItems: 1