| Message ID | 091f7989226169722220e95e0e838d2d139eb286.1619022192.git.drv@mailo.com |
|---|---|
| State | New |
| Headers | show |
| Series | staging: media: atomisp: code cleanup fixes | expand |
diff --git a/drivers/staging/media/atomisp/i2c/atomisp-gc0310.c b/drivers/staging/media/atomisp/i2c/atomisp-gc0310.c index b572551f1a0d..7e4e123fdb52 100644 --- a/drivers/staging/media/atomisp/i2c/atomisp-gc0310.c +++ b/drivers/staging/media/atomisp/i2c/atomisp-gc0310.c @@ -1020,8 +1020,8 @@ static int gc0310_set_fmt(struct v4l2_subdev *sd, return -EINVAL; } - printk("%s: before gc0310_write_reg_array %s\n", __func__, - gc0310_res[dev->fmt_idx].desc); + dev_info(&client->dev, "%s: before gc0310_write_reg_array %s\n", + __func__, gc0310_res[dev->fmt_idx].desc); ret = startup(sd); if (ret) { dev_err(&client->dev, "gc0310 startup err\n");
It is better to use dev_info() instead of raw printk() call. This addresses the checkpatch complain for not using KERN_<LEVEL> facility in printk() call. Suggested-by: Fabio Aiuto <fabioaiuto83@gmail.com> Signed-off-by: Deepak R Varma <drv@mailo.com> --- Changes since v2: - Tag Fabio Auito for the patch suggestion Changes in v1: - implement following changes suggested by Fabio Aiuto a. use dev_info instead of pr_info b. update patch log message accordingly drivers/staging/media/atomisp/i2c/atomisp-gc0310.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)