| Message ID | 1418748817-18019-1-git-send-email-ola.liljedahl@linaro.org |
|---|---|
| State | Accepted |
| Commit | ffea5118bd71b396fa919d6fe23604836d18665c |
| Headers | show |
Please merge this patch ASAP. This is really a bug fix of the buffer implementation, the includer should not have to include header files needed by other header files! The new timer implementation needs this bug fix. On 7 January 2015 at 15:49, Stuart Haslam <stuart.haslam@arm.com> wrote: > On Tue, Dec 16, 2014 at 04:53:37PM +0000, Ola Liljedahl wrote: >> Signed-off-by: Ola Liljedahl <ola.liljedahl@linaro.org> > > Reviewed-by: Stuart Haslam <stuart.haslam@arm.com> > >> --- >> (This document/code contribution attached is provided under the terms of >> agreement LES-LTM-21309) >> platform/linux-generic/include/odp_buffer_inlines.h | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/platform/linux-generic/include/odp_buffer_inlines.h b/platform/linux-generic/include/odp_buffer_inlines.h >> index 6227482..529a7e8 100644 >> --- a/platform/linux-generic/include/odp_buffer_inlines.h >> +++ b/platform/linux-generic/include/odp_buffer_inlines.h >> @@ -17,6 +17,9 @@ >> extern "C" { >> #endif >> >> +#include <odp_buffer_internal.h> >> +#include <odp_buffer_pool_internal.h> >> + >> static inline odp_buffer_t odp_buffer_encode_handle(odp_buffer_hdr_t *hdr) >> { >> odp_buffer_bits_t handle; >> -- >> 1.9.1 >> >> >
Applied On 7 January 2015 at 09:50, Ola Liljedahl <ola.liljedahl@linaro.org> wrote: > Please merge this patch ASAP. This is really a bug fix of the buffer > implementation, the includer should not have to include header files > needed by other header files! The new timer implementation needs this > bug fix. > > On 7 January 2015 at 15:49, Stuart Haslam <stuart.haslam@arm.com> wrote: > > On Tue, Dec 16, 2014 at 04:53:37PM +0000, Ola Liljedahl wrote: > >> Signed-off-by: Ola Liljedahl <ola.liljedahl@linaro.org> > > > > Reviewed-by: Stuart Haslam <stuart.haslam@arm.com> > > > >> --- > >> (This document/code contribution attached is provided under the terms of > >> agreement LES-LTM-21309) > >> platform/linux-generic/include/odp_buffer_inlines.h | 3 +++ > >> 1 file changed, 3 insertions(+) > >> > >> diff --git a/platform/linux-generic/include/odp_buffer_inlines.h > b/platform/linux-generic/include/odp_buffer_inlines.h > >> index 6227482..529a7e8 100644 > >> --- a/platform/linux-generic/include/odp_buffer_inlines.h > >> +++ b/platform/linux-generic/include/odp_buffer_inlines.h > >> @@ -17,6 +17,9 @@ > >> extern "C" { > >> #endif > >> > >> +#include <odp_buffer_internal.h> > >> +#include <odp_buffer_pool_internal.h> > >> + > >> static inline odp_buffer_t odp_buffer_encode_handle(odp_buffer_hdr_t > *hdr) > >> { > >> odp_buffer_bits_t handle; > >> -- > >> 1.9.1 > >> > >> > > > > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org > http://lists.linaro.org/mailman/listinfo/lng-odp >
diff --git a/platform/linux-generic/include/odp_buffer_inlines.h b/platform/linux-generic/include/odp_buffer_inlines.h index 6227482..529a7e8 100644 --- a/platform/linux-generic/include/odp_buffer_inlines.h +++ b/platform/linux-generic/include/odp_buffer_inlines.h @@ -17,6 +17,9 @@ extern "C" { #endif +#include <odp_buffer_internal.h> +#include <odp_buffer_pool_internal.h> + static inline odp_buffer_t odp_buffer_encode_handle(odp_buffer_hdr_t *hdr) { odp_buffer_bits_t handle;
Signed-off-by: Ola Liljedahl <ola.liljedahl@linaro.org> --- (This document/code contribution attached is provided under the terms of agreement LES-LTM-21309) platform/linux-generic/include/odp_buffer_inlines.h | 3 +++ 1 file changed, 3 insertions(+)