| Message ID | 1418155527-57884-1-git-send-email-mike.holmes@linaro.org |
|---|---|
| State | Accepted |
| Commit | 6bec0f95c14951572e679e5b7098f87fbe57819a |
| Headers | show |
On 10 December 2014 at 08:23, Stuart Haslam <stuart.haslam@arm.com> wrote: > On Tue, Dec 09, 2014 at 08:05:27PM +0000, Mike Holmes wrote: > > Works around https://bugs.linaro.org/show_bug.cgi?id=975 > > > > Signed-off-by: Mike Holmes <mike.holmes@linaro.org> > > --- > > test/validation/Makefile.am | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/test/validation/Makefile.am b/test/validation/Makefile.am > > index 3670c76..d0b5426 100644 > > --- a/test/validation/Makefile.am > > +++ b/test/validation/Makefile.am > > @@ -25,3 +25,7 @@ dist_odp_crypto_SOURCES = > crypto/odp_crypto_test_async_inp.c \ > > odp_crypto.c common/odp_cunit_common.c > > dist_odp_shm_SOURCES = odp_shm.c common/odp_cunit_common.c > > dist_odp_schedule_SOURCES = odp_schedule.c common/odp_cunit_common.c > > + > > +#For Linux generic the unimplemented crypto API functions break the > > +#regression TODO: https://bugs.linaro.org/show_bug.cgi?id=975 > > +XFAIL_TESTS=odp_crypto > > This seems a bit coarse grained. It now expects *all* tests in > odp_crypto to fail on *all* platforms, so you could easily mask other > failures that aren't really expected. > Other platforms do not set XFAIL > > How about removing the specific cunit test that fails for now?.. > or perhaps adding a special case for unimplemented APIs failures. > We need to fix crypto - Taras has some ideas, but this works on freescale we cant take it out. > > Anyhow, what's the problem with the test failing? it's a fairly good > reminder that something needs to be fixed (much harder to ignore than a > bugzilla entry) > > It really plays havoc with CI and other scripts, we know crypto on linux-generic is not fit for 1.0 but it should not break all the other testing whilst we fix it. > -- > Stuart. > >
On 11 December 2014 at 11:15, Stuart Haslam <stuart.haslam@arm.com> wrote: > On Wed, Dec 10, 2014 at 01:29:24PM +0000, Mike Holmes wrote: > > On 10 December 2014 at 08:23, Stuart Haslam <stuart.haslam@arm.com> > wrote: > > On Tue, Dec 09, 2014 at 08:05:27PM +0000, Mike Holmes wrote: > > > Works around https://bugs.linaro.org/show_bug.cgi?id=975 > > > > > > Signed-off-by: Mike Holmes <mike.holmes@linaro.org> > > Reviewed-by: Stuart Haslam <stuart.haslam@arm.com> > > On the understanding that this is a work around but we should look into > a better solution (e.g. having cunit report skipped tests separately > from failed tests). > Completely agree. I have mailed the CUnit maintainers to gauge their interest in the feature - their list is very low volume. Anders has a patched CUnIt with a skip patch applied that was on the CUnit list, but it is not yet working correctly - volunteers to fix it ? Mike > > > > --- > > > test/validation/Makefile.am | 4 ++++ > > > 1 file changed, 4 insertions(+) > > > > > > diff --git a/test/validation/Makefile.am b/test/validation/Makefile.am > > > index 3670c76..d0b5426 100644 > > > --- a/test/validation/Makefile.am > > > +++ b/test/validation/Makefile.am > > > @@ -25,3 +25,7 @@ dist_odp_crypto_SOURCES = > crypto/odp_crypto_test_async_inp.c \ > > > odp_crypto.c common/odp_cunit_common.c > > > dist_odp_shm_SOURCES = odp_shm.c common/odp_cunit_common.c > > > dist_odp_schedule_SOURCES = odp_schedule.c common/odp_cunit_common.c > > > + > > > +#For Linux generic the unimplemented crypto API functions break the > > > +#regression TODO: https://bugs.linaro.org/show_bug.cgi?id=975 > > > +XFAIL_TESTS=odp_crypto > > > > This seems a bit coarse grained. It now expects *all* tests in > > odp_crypto to fail on *all* platforms, so you could easily mask other > > failures that aren't really expected. > > > > Other platforms do not set XFAIL > > > > > > How about removing the specific cunit test that fails for now?.. > > or perhaps adding a special case for unimplemented APIs failures. > > > > We need to fix crypto - Taras has some ideas, but this works on > freescale we cant take it out. > > > > > > Anyhow, what's the problem with the test failing? it's a fairly good > > reminder that something needs to be fixed (much harder to ignore than a > > bugzilla entry) > > > > > > It really plays havoc with CI and other scripts, we know crypto on > linux-generic is not fit for 1.0 but it should not break all the other > testing whilst we fix it. > > > >
Merged, Maxim. On 12/09/2014 11:05 PM, Mike Holmes wrote: > Works around https://bugs.linaro.org/show_bug.cgi?id=975 > > Signed-off-by: Mike Holmes <mike.holmes@linaro.org> > --- > test/validation/Makefile.am | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/test/validation/Makefile.am b/test/validation/Makefile.am > index 3670c76..d0b5426 100644 > --- a/test/validation/Makefile.am > +++ b/test/validation/Makefile.am > @@ -25,3 +25,7 @@ dist_odp_crypto_SOURCES = crypto/odp_crypto_test_async_inp.c \ > odp_crypto.c common/odp_cunit_common.c > dist_odp_shm_SOURCES = odp_shm.c common/odp_cunit_common.c > dist_odp_schedule_SOURCES = odp_schedule.c common/odp_cunit_common.c > + > +#For Linux generic the unimplemented crypto API functions break the > +#regression TODO: https://bugs.linaro.org/show_bug.cgi?id=975 > +XFAIL_TESTS=odp_crypto
diff --git a/test/validation/Makefile.am b/test/validation/Makefile.am index 3670c76..d0b5426 100644 --- a/test/validation/Makefile.am +++ b/test/validation/Makefile.am @@ -25,3 +25,7 @@ dist_odp_crypto_SOURCES = crypto/odp_crypto_test_async_inp.c \ odp_crypto.c common/odp_cunit_common.c dist_odp_shm_SOURCES = odp_shm.c common/odp_cunit_common.c dist_odp_schedule_SOURCES = odp_schedule.c common/odp_cunit_common.c + +#For Linux generic the unimplemented crypto API functions break the +#regression TODO: https://bugs.linaro.org/show_bug.cgi?id=975 +XFAIL_TESTS=odp_crypto
Works around https://bugs.linaro.org/show_bug.cgi?id=975 Signed-off-by: Mike Holmes <mike.holmes@linaro.org> --- test/validation/Makefile.am | 4 ++++ 1 file changed, 4 insertions(+)