| Message ID | 1418132339-15099-1-git-send-email-maxim.uvarov@linaro.org |
|---|---|
| State | New |
| Headers | show |
On 2014-12-09 16:38, Maxim Uvarov wrote: > if $AM_LDFLAGS is empty then libs output shifted with white-spaces > according to other prints. Also line up ld and clfags. > > Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org> > --- > configure.ac | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/configure.ac b/configure.ac > index 2f27261..f792a68 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -112,8 +112,8 @@ AX_PTHREAD([CC="$PTHREAD_CC"], [ > exit -1 > ]) > LIBS="$PTHREAD_LIBS $LIBS" > -AM_CFLAGS="$AM_CFLAGS $PTHREAD_CFLAGS" > -AM_LDFLAGS="$AM_LDFLAGS $PTHREAD_LDFLAGS" > +AM_CFLAGS="$PTHREAD_CFLAGS $AM_CFLAGS" you removed the space before "-pthread" but you added one extra after instead. Cheers, Anders
On 12/11/2014 04:12 PM, Anders Roxell wrote: > On 2014-12-09 16:38, Maxim Uvarov wrote: >> if $AM_LDFLAGS is empty then libs output shifted with white-spaces >> according to other prints. Also line up ld and clfags. >> >> Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org> >> --- >> configure.ac | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/configure.ac b/configure.ac >> index 2f27261..f792a68 100644 >> --- a/configure.ac >> +++ b/configure.ac >> @@ -112,8 +112,8 @@ AX_PTHREAD([CC="$PTHREAD_CC"], [ >> exit -1 >> ]) >> LIBS="$PTHREAD_LIBS $LIBS" >> -AM_CFLAGS="$AM_CFLAGS $PTHREAD_CFLAGS" >> -AM_LDFLAGS="$AM_LDFLAGS $PTHREAD_LDFLAGS" >> +AM_CFLAGS="$PTHREAD_CFLAGS $AM_CFLAGS" > you removed the space before "-pthread" but you added one extra after > instead. > > > Cheers, > Anders This patch replaced with: [PATCH] normalize configure flags Looks like I should be more specific. Please drop this patch. Maxim.
diff --git a/configure.ac b/configure.ac index 2f27261..f792a68 100644 --- a/configure.ac +++ b/configure.ac @@ -112,8 +112,8 @@ AX_PTHREAD([CC="$PTHREAD_CC"], [ exit -1 ]) LIBS="$PTHREAD_LIBS $LIBS" -AM_CFLAGS="$AM_CFLAGS $PTHREAD_CFLAGS" -AM_LDFLAGS="$AM_LDFLAGS $PTHREAD_LDFLAGS" +AM_CFLAGS="$PTHREAD_CFLAGS $AM_CFLAGS" +AM_LDFLAGS="$PTHREAD_LDFLAGS $AM_LDFLAGS" ########################################################################## # Check for doxygen availability @@ -209,7 +209,7 @@ AC_SEARCH_LIBS([timer_create],[rt posix4]) ########################################################################## # distribute the changed variables among the Makefiles -AM_LDFLAGS="$AM_LDFLAGS -pthread -lrt" +AM_LDFLAGS="-pthread -lrt $AM_LDFLAGS" AC_SUBST([LIBS]) AC_SUBST([AM_CFLAGS])
if $AM_LDFLAGS is empty then libs output shifted with white-spaces according to other prints. Also line up ld and clfags. Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org> --- configure.ac | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)