| Message ID | 1618325157-5774-1-git-send-email-michal.vokac@ysoft.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | ARM: dts: imx6dl-yapp4: Fix RGMII connection to QCA8334 switch | expand |
On Tue, Apr 13, 2021 at 04:45:57PM +0200, Michal Vokáč wrote: > The FEC does not have a PHY so it should not have a phy-handle. It is > connected to the switch at RGMII level so we need a fixed-link sub-node > on both ends. > > This was not a problem until the qca8k.c driver was converted to PHYLINK > by commit b3591c2a3661 ("net: dsa: qca8k: Switch to PHYLINK instead of > PHYLIB"). That commit revealed the FEC configuration was not correct. > > Fixes: 87489ec3a77f ("ARM: dts: imx: Add Y Soft IOTA Draco, Hydra and Ursa boards") > Cc: stable@vger.kernel.org > Signed-off-by: Michal Vokáč <michal.vokac@ysoft.com> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew
On Tue, Apr 13, 2021 at 04:45:57PM +0200, Michal Vokáč wrote: > The FEC does not have a PHY so it should not have a phy-handle. It is > connected to the switch at RGMII level so we need a fixed-link sub-node > on both ends. > > This was not a problem until the qca8k.c driver was converted to PHYLINK > by commit b3591c2a3661 ("net: dsa: qca8k: Switch to PHYLINK instead of > PHYLIB"). That commit revealed the FEC configuration was not correct. > > Fixes: 87489ec3a77f ("ARM: dts: imx: Add Y Soft IOTA Draco, Hydra and Ursa boards") > Cc: stable@vger.kernel.org > Signed-off-by: Michal Vokáč <michal.vokac@ysoft.com> Applied, thanks.
diff --git a/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi b/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi index 111d4d331f98..686dab57a1e4 100644 --- a/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi +++ b/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi @@ -121,9 +121,13 @@ phy-reset-gpios = <&gpio1 25 GPIO_ACTIVE_LOW>; phy-reset-duration = <20>; phy-supply = <&sw2_reg>; - phy-handle = <ðphy0>; status = "okay"; + fixed-link { + speed = <1000>; + full-duplex; + }; + mdio { #address-cells = <1>; #size-cells = <0>;
The FEC does not have a PHY so it should not have a phy-handle. It is connected to the switch at RGMII level so we need a fixed-link sub-node on both ends. This was not a problem until the qca8k.c driver was converted to PHYLINK by commit b3591c2a3661 ("net: dsa: qca8k: Switch to PHYLINK instead of PHYLIB"). That commit revealed the FEC configuration was not correct. Fixes: 87489ec3a77f ("ARM: dts: imx: Add Y Soft IOTA Draco, Hydra and Ursa boards") Cc: stable@vger.kernel.org Signed-off-by: Michal Vokáč <michal.vokac@ysoft.com> --- arch/arm/boot/dts/imx6dl-yapp4-common.dtsi | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)