diff mbox

test: Remove use of ODP_UNUSED

Message ID 1417810018-16534-1-git-send-email-mike.holmes@linaro.org
State Superseded
Headers show

Commit Message

Mike Holmes Dec. 5, 2014, 8:06 p.m. UTC
ODP_UNUSED is an ODP API macro that should not be used by external applications
including tests.

Signed-off-by: Mike Holmes <mike.holmes@linaro.org>
---
 test/api_test/odp_ring_test.c  | 3 ++-
 test/api_test/odp_shm_test.c   | 3 ++-
 test/api_test/odp_timer_ping.c | 3 ++-
 3 files changed, 6 insertions(+), 3 deletions(-)

Comments

Ciprian Barbu Dec. 9, 2014, 3:51 p.m. UTC | #1
On Fri, Dec 5, 2014 at 10:06 PM, Mike Holmes <mike.holmes@linaro.org> wrote:
> ODP_UNUSED is an ODP API macro that should not be used by external applications
> including tests.
>
> Signed-off-by: Mike Holmes <mike.holmes@linaro.org>

Reviewed-by: Ciprian Barbu <ciprian.barbu@linaro.org>

> ---
>  test/api_test/odp_ring_test.c  | 3 ++-
>  test/api_test/odp_shm_test.c   | 3 ++-
>  test/api_test/odp_timer_ping.c | 3 ++-
>  3 files changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/test/api_test/odp_ring_test.c b/test/api_test/odp_ring_test.c
> index 15a9a7d..54398f0 100644
> --- a/test/api_test/odp_ring_test.c
> +++ b/test/api_test/odp_ring_test.c
> @@ -418,7 +418,8 @@ static void *test_ring(void *arg)
>  }
>
>
> -int main(int argc ODP_UNUSED, char *argv[] ODP_UNUSED)
> +int main(int argc __attribute__((__unused__)),
> +        char *argv[] __attribute__((__unused__)))
>  {
>         ring_arg_t rarg;
>
> diff --git a/test/api_test/odp_shm_test.c b/test/api_test/odp_shm_test.c
> index 5cfde7d..5163337 100644
> --- a/test/api_test/odp_shm_test.c
> +++ b/test/api_test/odp_shm_test.c
> @@ -40,7 +40,8 @@ static void *run_thread(void *arg)
>         return parg;
>  }
>
> -int main(int argc ODP_UNUSED, char *argv[] ODP_UNUSED)
> +int main(int argc __attribute__((__unused__)),
> +        char *argv[] __attribute__((__unused__)))
>  {
>         pthrd_arg thrdarg;
>         odp_shm_t shm;
> diff --git a/test/api_test/odp_timer_ping.c b/test/api_test/odp_timer_ping.c
> index 48f1885..d958815 100644
> --- a/test/api_test/odp_timer_ping.c
> +++ b/test/api_test/odp_timer_ping.c
> @@ -315,7 +315,8 @@ static int ping_init(int count, char *name[])
>         return 0;
>  }
>
> -int main(int argc ODP_UNUSED, char *argv[] ODP_UNUSED)
> +int main(int argc __attribute__((__unused__)),
> +        char *argv[] __attribute__((__unused__)))
>  {
>         odph_linux_pthread_t thread_tbl[MAX_WORKERS];
>         ping_arg_t pingarg;
> --
> 2.1.0
>
>
> _______________________________________________
> lng-odp mailing list
> lng-odp@lists.linaro.org
> http://lists.linaro.org/mailman/listinfo/lng-odp
Ciprian Barbu Dec. 9, 2014, 4:11 p.m. UTC | #2
On Tue, Dec 9, 2014 at 5:51 PM, Ciprian Barbu <ciprian.barbu@linaro.org> wrote:
> On Fri, Dec 5, 2014 at 10:06 PM, Mike Holmes <mike.holmes@linaro.org> wrote:
>> ODP_UNUSED is an ODP API macro that should not be used by external applications
>> including tests.
>>
>> Signed-off-by: Mike Holmes <mike.holmes@linaro.org>
>
> Reviewed-by: Ciprian Barbu <ciprian.barbu@linaro.org>

Ignore, Mike sent this patch in a new series.

>
>> ---
>>  test/api_test/odp_ring_test.c  | 3 ++-
>>  test/api_test/odp_shm_test.c   | 3 ++-
>>  test/api_test/odp_timer_ping.c | 3 ++-
>>  3 files changed, 6 insertions(+), 3 deletions(-)
>>
>> diff --git a/test/api_test/odp_ring_test.c b/test/api_test/odp_ring_test.c
>> index 15a9a7d..54398f0 100644
>> --- a/test/api_test/odp_ring_test.c
>> +++ b/test/api_test/odp_ring_test.c
>> @@ -418,7 +418,8 @@ static void *test_ring(void *arg)
>>  }
>>
>>
>> -int main(int argc ODP_UNUSED, char *argv[] ODP_UNUSED)
>> +int main(int argc __attribute__((__unused__)),
>> +        char *argv[] __attribute__((__unused__)))
>>  {
>>         ring_arg_t rarg;
>>
>> diff --git a/test/api_test/odp_shm_test.c b/test/api_test/odp_shm_test.c
>> index 5cfde7d..5163337 100644
>> --- a/test/api_test/odp_shm_test.c
>> +++ b/test/api_test/odp_shm_test.c
>> @@ -40,7 +40,8 @@ static void *run_thread(void *arg)
>>         return parg;
>>  }
>>
>> -int main(int argc ODP_UNUSED, char *argv[] ODP_UNUSED)
>> +int main(int argc __attribute__((__unused__)),
>> +        char *argv[] __attribute__((__unused__)))
>>  {
>>         pthrd_arg thrdarg;
>>         odp_shm_t shm;
>> diff --git a/test/api_test/odp_timer_ping.c b/test/api_test/odp_timer_ping.c
>> index 48f1885..d958815 100644
>> --- a/test/api_test/odp_timer_ping.c
>> +++ b/test/api_test/odp_timer_ping.c
>> @@ -315,7 +315,8 @@ static int ping_init(int count, char *name[])
>>         return 0;
>>  }
>>
>> -int main(int argc ODP_UNUSED, char *argv[] ODP_UNUSED)
>> +int main(int argc __attribute__((__unused__)),
>> +        char *argv[] __attribute__((__unused__)))
>>  {
>>         odph_linux_pthread_t thread_tbl[MAX_WORKERS];
>>         ping_arg_t pingarg;
>> --
>> 2.1.0
>>
>>
>> _______________________________________________
>> lng-odp mailing list
>> lng-odp@lists.linaro.org
>> http://lists.linaro.org/mailman/listinfo/lng-odp
diff mbox

Patch

diff --git a/test/api_test/odp_ring_test.c b/test/api_test/odp_ring_test.c
index 15a9a7d..54398f0 100644
--- a/test/api_test/odp_ring_test.c
+++ b/test/api_test/odp_ring_test.c
@@ -418,7 +418,8 @@  static void *test_ring(void *arg)
 }
 
 
-int main(int argc ODP_UNUSED, char *argv[] ODP_UNUSED)
+int main(int argc __attribute__((__unused__)),
+	 char *argv[] __attribute__((__unused__)))
 {
 	ring_arg_t rarg;
 
diff --git a/test/api_test/odp_shm_test.c b/test/api_test/odp_shm_test.c
index 5cfde7d..5163337 100644
--- a/test/api_test/odp_shm_test.c
+++ b/test/api_test/odp_shm_test.c
@@ -40,7 +40,8 @@  static void *run_thread(void *arg)
 	return parg;
 }
 
-int main(int argc ODP_UNUSED, char *argv[] ODP_UNUSED)
+int main(int argc __attribute__((__unused__)),
+	 char *argv[] __attribute__((__unused__)))
 {
 	pthrd_arg thrdarg;
 	odp_shm_t shm;
diff --git a/test/api_test/odp_timer_ping.c b/test/api_test/odp_timer_ping.c
index 48f1885..d958815 100644
--- a/test/api_test/odp_timer_ping.c
+++ b/test/api_test/odp_timer_ping.c
@@ -315,7 +315,8 @@  static int ping_init(int count, char *name[])
 	return 0;
 }
 
-int main(int argc ODP_UNUSED, char *argv[] ODP_UNUSED)
+int main(int argc __attribute__((__unused__)),
+	 char *argv[] __attribute__((__unused__)))
 {
 	odph_linux_pthread_t thread_tbl[MAX_WORKERS];
 	ping_arg_t pingarg;