diff mbox series

staging: media: atomisp: Minor code style changes

Message ID 20210412160203.6925-1-vrzh@vrzh.net
State Superseded
Headers show
Series staging: media: atomisp: Minor code style changes | expand

Commit Message

Martiros Shakhzadyan April 12, 2021, 4:02 p.m. UTC
Fixed line continuation and parenthesis alignment issues.

Signed-off-by: Martiros Shakhzadyan <vrzh@vrzh.net>
---
 drivers/staging/media/atomisp/i2c/atomisp-ov2722.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Comments

Hans Verkuil April 13, 2021, 2:41 p.m. UTC | #1
Please repost with a '[PATCHv3]' in the subject.

This version should have been '[PATCHv2]', but you forgot the v2 part :-)

It's important, since now I had no indication that the previous patch was superseded
and I tried to apply both, thus discovering that the older one should have been skipped.

Regards,

	Hans

On 12/04/2021 18:02, Martiros Shakhzadyan wrote:
> Fixed line continuation and parenthesis alignment issues.

> 

> Signed-off-by: Martiros Shakhzadyan <vrzh@vrzh.net>

> ---

>  drivers/staging/media/atomisp/i2c/atomisp-ov2722.c | 8 ++++----

>  1 file changed, 4 insertions(+), 4 deletions(-)

> 

> diff --git a/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c b/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c

> index 912eadaffc44..90a985ee25fa 100644

> --- a/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c

> +++ b/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c

> @@ -49,8 +49,8 @@ static int ov2722_read_reg(struct i2c_client *client,

>  		return -ENODEV;

>  	}

>  

> -	if (data_length != OV2722_8BIT && data_length != OV2722_16BIT

> -	    && data_length != OV2722_32BIT) {

> +	if (data_length != OV2722_8BIT && data_length != OV2722_16BIT &&

> +	    data_length != OV2722_32BIT) {

>  		dev_err(&client->dev, "%s error, invalid data length\n",

>  			__func__);

>  		return -EINVAL;

> @@ -212,8 +212,8 @@ static int __ov2722_buf_reg_array(struct i2c_client *client,

>  }

>  

>  static int __ov2722_write_reg_is_consecutive(struct i2c_client *client,

> -	struct ov2722_write_ctrl *ctrl,

> -	const struct ov2722_reg *next)

> +					     struct ov2722_write_ctrl *ctrl,

> +					     const struct ov2722_reg *next)

>  {

>  	if (ctrl->index == 0)

>  		return 1;

>
Martiros Shakhzadyan April 13, 2021, 5:55 p.m. UTC | #2
On Tue, Apr 13, 2021 at 04:41:02PM +0200, Hans Verkuil wrote:
> Please repost with a '[PATCHv3]' in the subject.

> 

> This version should have been '[PATCHv2]', but you forgot the v2 part :-)

> 

> It's important, since now I had no indication that the previous patch was superseded

> and I tried to apply both, thus discovering that the older one should have been skipped.

> 

> Regards,

> 

> 	Hans

> 

Got it! Will do that now - thanks for your patience :)
> On 12/04/2021 18:02, Martiros Shakhzadyan wrote:

> > Fixed line continuation and parenthesis alignment issues.

> > 

> > Signed-off-by: Martiros Shakhzadyan <vrzh@vrzh.net>

> > ---

> >  drivers/staging/media/atomisp/i2c/atomisp-ov2722.c | 8 ++++----

> >  1 file changed, 4 insertions(+), 4 deletions(-)

> > 

> > diff --git a/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c b/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c

> > index 912eadaffc44..90a985ee25fa 100644

> > --- a/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c

> > +++ b/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c

> > @@ -49,8 +49,8 @@ static int ov2722_read_reg(struct i2c_client *client,

> >  		return -ENODEV;

> >  	}

> >  

> > -	if (data_length != OV2722_8BIT && data_length != OV2722_16BIT

> > -	    && data_length != OV2722_32BIT) {

> > +	if (data_length != OV2722_8BIT && data_length != OV2722_16BIT &&

> > +	    data_length != OV2722_32BIT) {

> >  		dev_err(&client->dev, "%s error, invalid data length\n",

> >  			__func__);

> >  		return -EINVAL;

> > @@ -212,8 +212,8 @@ static int __ov2722_buf_reg_array(struct i2c_client *client,

> >  }

> >  

> >  static int __ov2722_write_reg_is_consecutive(struct i2c_client *client,

> > -	struct ov2722_write_ctrl *ctrl,

> > -	const struct ov2722_reg *next)

> > +					     struct ov2722_write_ctrl *ctrl,

> > +					     const struct ov2722_reg *next)

> >  {

> >  	if (ctrl->index == 0)

> >  		return 1;

> > 

>
diff mbox series

Patch

diff --git a/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c b/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c
index 912eadaffc44..90a985ee25fa 100644
--- a/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c
+++ b/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c
@@ -49,8 +49,8 @@  static int ov2722_read_reg(struct i2c_client *client,
 		return -ENODEV;
 	}
 
-	if (data_length != OV2722_8BIT && data_length != OV2722_16BIT
-	    && data_length != OV2722_32BIT) {
+	if (data_length != OV2722_8BIT && data_length != OV2722_16BIT &&
+	    data_length != OV2722_32BIT) {
 		dev_err(&client->dev, "%s error, invalid data length\n",
 			__func__);
 		return -EINVAL;
@@ -212,8 +212,8 @@  static int __ov2722_buf_reg_array(struct i2c_client *client,
 }
 
 static int __ov2722_write_reg_is_consecutive(struct i2c_client *client,
-	struct ov2722_write_ctrl *ctrl,
-	const struct ov2722_reg *next)
+					     struct ov2722_write_ctrl *ctrl,
+					     const struct ov2722_reg *next)
 {
 	if (ctrl->index == 0)
 		return 1;