diff mbox

[V2,06/26] thermal: cpu_cooling: fix doc comment over struct cpufreq_cooling_device

Message ID 65fe28eb30ff75ec96c29f85c0822eecf23879bf.1417664938.git.viresh.kumar@linaro.org
State Accepted
Commit beca6053fc21bbe0ed0242a3f79c0cca5749a90f
Headers show

Commit Message

Viresh Kumar Dec. 4, 2014, 4:11 a.m. UTC
cooling_cpufreq_lock isn't used to protect this structure and so the comment
over it is outdated. Fix it.

Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
 drivers/thermal/cpu_cooling.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

Comments

Viresh Kumar Dec. 4, 2014, 10:36 a.m. UTC | #1
On 4 December 2014 at 16:02, Javi Merino <javi.merino@arm.com> wrote:
> Instead of deleting this comment, move it to where it belongs.  From
> my understanding, the cooling_cpufreq_lock protects the
> cpufreq_dev_list.  Can you move the comment there?

I will add a separate patch to add comment over cooling_cpufreq_lock
to define what all it protects.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-pm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/thermal/cpu_cooling.c b/drivers/thermal/cpu_cooling.c
index 6f2d41e..cc10641 100644
--- a/drivers/thermal/cpu_cooling.c
+++ b/drivers/thermal/cpu_cooling.c
@@ -40,9 +40,8 @@ 
  *	frequency.
  * @allowed_cpus: all the cpus involved for this cpufreq_cooling_device.
  *
- * This structure is required for keeping information of each
- * cpufreq_cooling_device registered. In order to prevent corruption of this a
- * mutex lock cooling_cpufreq_lock is used.
+ * This structure is required for keeping information of each registered
+ * cpufreq_cooling_device.
  */
 struct cpufreq_cooling_device {
 	int id;