diff mbox series

[next] Bluetooth: virtio_bt: add missing null pointer check on alloc_skb call return

Message ID 20210409165314.671165-1-colin.king@canonical.com
State Accepted
Commit c6bc94970af8d4eaef42491918a8cdf4f7510492
Headers show
Series [next] Bluetooth: virtio_bt: add missing null pointer check on alloc_skb call return | expand

Commit Message

Colin King April 9, 2021, 4:53 p.m. UTC 
From: Colin Ian King <colin.king@canonical.com>

The call to alloc_skb with the GFP_KERNEL flag can return a null sk_buff
pointer, so add a null check to avoid any null pointer deference issues.

Addresses-Coverity: ("Dereference null return value")
Fixes: afd2daa26c7a ("Bluetooth: Add support for virtio transport driver")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/bluetooth/virtio_bt.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Marcel Holtmann April 11, 2021, 11:56 a.m. UTC | #1 
Hi Colin,

> The call to alloc_skb with the GFP_KERNEL flag can return a null sk_buff

> pointer, so add a null check to avoid any null pointer deference issues.

> 

> Addresses-Coverity: ("Dereference null return value")

> Fixes: afd2daa26c7a ("Bluetooth: Add support for virtio transport driver")

> Signed-off-by: Colin Ian King <colin.king@canonical.com>

> ---

> drivers/bluetooth/virtio_bt.c | 2 ++

> 1 file changed, 2 insertions(+)


patch has been applied to bluetooth-next tree.

Regards

Marcel
diff mbox series

Patch

diff --git a/drivers/bluetooth/virtio_bt.c b/drivers/bluetooth/virtio_bt.c
index c804db7e90f8..5f82574236c0 100644
--- a/drivers/bluetooth/virtio_bt.c
+++ b/drivers/bluetooth/virtio_bt.c
@@ -34,6 +34,8 @@  static int virtbt_add_inbuf(struct virtio_bluetooth *vbt)
 	int err;
 
 	skb = alloc_skb(1000, GFP_KERNEL);
+	if (!skb)
+		return -ENOMEM;
 	sg_init_one(sg, skb->data, 1000);
 
 	err = virtqueue_add_inbuf(vq, sg, 1, skb, GFP_KERNEL);