| Message ID | 1617089946-48078-6-git-send-email-yekai13@huawei.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | bug fix and clear coding style | expand |
On Tue, Mar 30, 2021 at 03:39:06PM +0800, Kai Ye wrote: > Add clear data operation for sge data. > > Signed-off-by: Kai Ye <yekai13@huawei.com> > --- > drivers/crypto/hisilicon/sgl.c | 14 +++++++++++++- > 1 file changed, 13 insertions(+), 1 deletion(-) > > diff --git a/drivers/crypto/hisilicon/sgl.c b/drivers/crypto/hisilicon/sgl.c > index c618aaf..7a58ab3 100644 > --- a/drivers/crypto/hisilicon/sgl.c > +++ b/drivers/crypto/hisilicon/sgl.c > @@ -189,6 +189,18 @@ static void update_hw_sgl_sum_sge(struct hisi_acc_hw_sgl *hw_sgl, u16 sum) > hw_sgl->entry_sum_in_chain = cpu_to_le16(sum); > } > > +static void clear_hw_sgl_sge(struct hisi_acc_hw_sgl *hw_sgl) > +{ > + struct acc_hw_sge *hw_sge = hw_sgl->sge_entries; > + int i; > + > + for (i = 0; i < hw_sgl->entry_sum_in_sgl; i++) { > + hw_sge[i].page_ctrl = NULL; > + hw_sge[i].buf = 0; > + hw_sge[i].len = 0; > + } > +} This causes a new sparse warning: CHECK ../drivers/crypto/hisilicon/sgl.c ../drivers/crypto/hisilicon/sgl.c:200:31: warning: restricted __le16 degrades to integer Please fix. Thanks, -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
diff --git a/drivers/crypto/hisilicon/sgl.c b/drivers/crypto/hisilicon/sgl.c index c618aaf..7a58ab3 100644 --- a/drivers/crypto/hisilicon/sgl.c +++ b/drivers/crypto/hisilicon/sgl.c @@ -189,6 +189,18 @@ static void update_hw_sgl_sum_sge(struct hisi_acc_hw_sgl *hw_sgl, u16 sum) hw_sgl->entry_sum_in_chain = cpu_to_le16(sum); } +static void clear_hw_sgl_sge(struct hisi_acc_hw_sgl *hw_sgl) +{ + struct acc_hw_sge *hw_sge = hw_sgl->sge_entries; + int i; + + for (i = 0; i < hw_sgl->entry_sum_in_sgl; i++) { + hw_sge[i].page_ctrl = NULL; + hw_sge[i].buf = 0; + hw_sge[i].len = 0; + } +} + /** * hisi_acc_sg_buf_map_to_hw_sgl - Map a scatterlist to a hw sgl. * @dev: The device which hw sgl belongs to. @@ -266,7 +278,7 @@ void hisi_acc_sg_buf_unmap(struct device *dev, struct scatterlist *sgl, return; dma_unmap_sg(dev, sgl, sg_nents(sgl), DMA_BIDIRECTIONAL); - + clear_hw_sgl_sge(hw_sgl); hw_sgl->entry_sum_in_chain = 0; hw_sgl->entry_sum_in_sgl = 0; hw_sgl->entry_length_in_sgl = 0;
Add clear data operation for sge data. Signed-off-by: Kai Ye <yekai13@huawei.com> --- drivers/crypto/hisilicon/sgl.c | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-)