diff mbox

[1/3] usb: phy: introduce usb_phy_set_event interface

Message ID 40513430786f3190776ee4a180c2486812048a6b.1416390389.git.kiran.kumar@linaro.org
State Superseded
Headers show

Commit Message

Kiran Kumar Raparthy Nov. 19, 2014, 10:43 a.m. UTC
From: Todd Poynor <toddpoynor@google.com>

usb: phy: introduce usb_phy_set_event interface

PHY drivers require a generic interface to handle per-PHY events.

usb_phy_set_event interface sets event to phy event.
PHY drivers call this interface for each phy event.

Cc: Felipe Balbi <balbi@ti.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org
Cc: linux-usb@vger.kernel.org
Cc: Android Kernel Team <kernel-team@android.com>
Cc: John Stultz <john.stultz@linaro.org>
Cc: Sumit Semwal <sumit.semwal@linaro.org>
Cc: Arve Hjřnnevĺg <arve@android.com>
Cc: Benoit Goby <benoit@android.com>
Signed-off-by: Todd Poynor <toddpoynor@google.com>
[kiran: Added context to commit message, squished build fixes
from Benoit Goby and Arve Hjřnnevĺg, changed wakelocks usage
to wakeupsource, merged Todd's refactoring logic and simplified
the structures and code and addressed community feedback]
Signed-off-by: Kiran Raparthy <kiran.kumar@linaro.org>
---
 drivers/usb/phy/phy.c   | 12 ++++++++++++
 include/linux/usb/phy.h |  5 +++++
 2 files changed, 17 insertions(+)

Comments

Todd Poynor Nov. 19, 2014, 4:36 p.m. UTC | #1
On Wed, Nov 19, 2014 at 2:43 AM, Kiran Kumar Raparthy
<kiran.kumar@linaro.org> wrote:
> From: Todd Poynor <toddpoynor@google.com>
>
> usb: phy: introduce usb_phy_set_event interface

Hi Kiran, this is new stuff that is all your own work and you deserve
the credit.

Thanks for working to get this feature in shape for mainline!


Todd
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Felipe Balbi Nov. 20, 2014, 7:54 p.m. UTC | #2
On Wed, Nov 19, 2014 at 08:36:22AM -0800, Todd Poynor wrote:
> On Wed, Nov 19, 2014 at 2:43 AM, Kiran Kumar Raparthy
> <kiran.kumar@linaro.org> wrote:
> > From: Todd Poynor <toddpoynor@google.com>
> >
> > usb: phy: introduce usb_phy_set_event interface
> 
> Hi Kiran, this is new stuff that is all your own work and you deserve
> the credit.
> 
> Thanks for working to get this feature in shape for mainline!

Kiran, what Todd is saying is that $subject is From: Kiran, do you want
to resend with that change ? I think this is ready to be moved into my
testing/next otherwise.
Kiran Kumar Raparthy Nov. 20, 2014, 11:31 p.m. UTC | #3
Hi Felipe,
On 21 November 2014 01:24, Felipe Balbi <balbi@ti.com> wrote:
> On Wed, Nov 19, 2014 at 08:36:22AM -0800, Todd Poynor wrote:
>> On Wed, Nov 19, 2014 at 2:43 AM, Kiran Kumar Raparthy
>> <kiran.kumar@linaro.org> wrote:
>> > From: Todd Poynor <toddpoynor@google.com>
>> >
>> > usb: phy: introduce usb_phy_set_event interface
>>
>> Hi Kiran, this is new stuff that is all your own work and you deserve
>> the credit.
>>
>> Thanks for working to get this feature in shape for mainline!
>
> Kiran, what Todd is saying is that $subject is From: Kiran, do you want
> to resend with that change ? I think this is ready to be moved into my
> testing/next otherwise.
I thanked him for his kind words.
No issues,I prefer not bothering you again by sending one more set of patches.
Please accept them if you feel the patches are good in shape.
Thank you so much for your time and support.
Regards,
Kiran

>
> --
> balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/usb/phy/phy.c b/drivers/usb/phy/phy.c
index 045cd30..2b1039e 100644
--- a/drivers/usb/phy/phy.c
+++ b/drivers/usb/phy/phy.c
@@ -444,3 +444,15 @@  int usb_bind_phy(const char *dev_name, u8 index,
 	return 0;
 }
 EXPORT_SYMBOL_GPL(usb_bind_phy);
+
+/**
+ * usb_phy_set_event - set event to phy event
+ * @x: the phy returned by usb_get_phy();
+ *
+ * This sets event to phy event
+ */
+void usb_phy_set_event(struct usb_phy *x, unsigned long event)
+{
+	x->last_event = event;
+}
+EXPORT_SYMBOL_GPL(usb_phy_set_event);
diff --git a/include/linux/usb/phy.h b/include/linux/usb/phy.h
index 353053a..3c713ff 100644
--- a/include/linux/usb/phy.h
+++ b/include/linux/usb/phy.h
@@ -210,6 +210,7 @@  extern void usb_put_phy(struct usb_phy *);
 extern void devm_usb_put_phy(struct device *dev, struct usb_phy *x);
 extern int usb_bind_phy(const char *dev_name, u8 index,
 				const char *phy_dev_name);
+extern void usb_phy_set_event(struct usb_phy *x, unsigned long event);
 #else
 static inline struct usb_phy *usb_get_phy(enum usb_phy_type type)
 {
@@ -251,6 +252,10 @@  static inline int usb_bind_phy(const char *dev_name, u8 index,
 {
 	return -EOPNOTSUPP;
 }
+
+static inline void usb_phy_set_event(struct usb_phy *x, unsigned long event)
+{
+}
 #endif
 
 static inline int