| Message ID | 20210329015938.20316-14-brad@pensando.io |
|---|---|
| State | New |
| Headers | show |
| Series | Support Pensando Elba SoC | expand |
On Mon, Mar 29, 2021 at 4:00 AM Brad Larson <brad@pensando.io> wrote: > New drivers should include <linux/gpio/driver.h> instead > of legacy <linux/gpio.h>. > > Signed-off-by: Brad Larson <brad@pensando.io> Fold into patch 1 as indicated by Greg. Yours, Linus Walleij
On Sun, Mar 28, 2021 at 11:48 PM Greg KH <gregkh@linuxfoundation.org> wrote: > > On Sun, Mar 28, 2021 at 06:59:38PM -0700, Brad Larson wrote: > > New drivers should include <linux/gpio/driver.h> instead > > of legacy <linux/gpio.h>. > > > > Signed-off-by: Brad Larson <brad@pensando.io> > > --- > > drivers/gpio/gpio-elba-spics.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/drivers/gpio/gpio-elba-spics.c b/drivers/gpio/gpio-elba-spics.c > > index 351bbaeea033..c0dce5333f35 100644 > > --- a/drivers/gpio/gpio-elba-spics.c > > +++ b/drivers/gpio/gpio-elba-spics.c > > @@ -6,11 +6,10 @@ > > */ > > > > #include <linux/err.h> > > -#include <linux/gpio.h> > > +#include <linux/gpio/driver.h> > > #include <linux/module.h> > > #include <linux/io.h> > > #include <linux/init.h> > > -//#include <linux/of.h> > > #include <linux/platform_device.h> > > #include <linux/spinlock.h> > > #include <linux/types.h> > > -- > > 2.17.1 > > > > This should be part of patch 1/13, do not add a problem and then fix it > up in the same patch series. > > thanks, > > greg k-h Yes, thanks. I'm laughing at myself today looking at that patch tagged at the end.
On Mon, Mar 29, 2021 at 6:44 AM Linus Walleij <linus.walleij@linaro.org> wrote: > > On Mon, Mar 29, 2021 at 4:00 AM Brad Larson <brad@pensando.io> wrote: > > > New drivers should include <linux/gpio/driver.h> instead > > of legacy <linux/gpio.h>. > > > > Signed-off-by: Brad Larson <brad@pensando.io> > > Fold into patch 1 as indicated by Greg. > > Yours, > Linus Walleij Yes, thanks for the quick review.
diff --git a/drivers/gpio/gpio-elba-spics.c b/drivers/gpio/gpio-elba-spics.c index 351bbaeea033..c0dce5333f35 100644 --- a/drivers/gpio/gpio-elba-spics.c +++ b/drivers/gpio/gpio-elba-spics.c @@ -6,11 +6,10 @@ */ #include <linux/err.h> -#include <linux/gpio.h> +#include <linux/gpio/driver.h> #include <linux/module.h> #include <linux/io.h> #include <linux/init.h> -//#include <linux/of.h> #include <linux/platform_device.h> #include <linux/spinlock.h> #include <linux/types.h>
New drivers should include <linux/gpio/driver.h> instead of legacy <linux/gpio.h>. Signed-off-by: Brad Larson <brad@pensando.io> --- drivers/gpio/gpio-elba-spics.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)