| Message ID | 20210328235507.19240-1-digetx@gmail.com |
|---|---|
| State | Accepted |
| Commit | 56cfe6f820a6315291eb5a1b82bb49633b993d3b |
| Headers | show |
| Series | [v1] Input: elants_i2c - drop zero-checking of ABS_MT_TOUCH_MAJOR resolution | expand |
On Mon, Mar 29, 2021 at 02:55:07AM +0300, Dmitry Osipenko wrote: > Drop unnecessary zero-checking of ABS_MT_TOUCH_MAJOR resolution since > there is no difference between setting resolution to 0 vs not setting > it at all. This change makes code cleaner a tad. > > Suggested-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> > Signed-off-by: Dmitry Osipenko <digetx@gmail.com> Applied, thank you. -- Dmitry
diff --git a/drivers/input/touchscreen/elants_i2c.c b/drivers/input/touchscreen/elants_i2c.c index 4c2b579f6c8b..7ddc24471819 100644 --- a/drivers/input/touchscreen/elants_i2c.c +++ b/drivers/input/touchscreen/elants_i2c.c @@ -1449,8 +1449,7 @@ static int elants_i2c_probe(struct i2c_client *client, input_abs_set_res(ts->input, ABS_MT_POSITION_X, ts->x_res); input_abs_set_res(ts->input, ABS_MT_POSITION_Y, ts->y_res); - if (ts->major_res > 0) - input_abs_set_res(ts->input, ABS_MT_TOUCH_MAJOR, ts->major_res); + input_abs_set_res(ts->input, ABS_MT_TOUCH_MAJOR, ts->major_res); error = input_mt_init_slots(ts->input, MAX_CONTACT_NUM, INPUT_MT_DIRECT | INPUT_MT_DROP_UNUSED);
Drop unnecessary zero-checking of ABS_MT_TOUCH_MAJOR resolution since there is no difference between setting resolution to 0 vs not setting it at all. This change makes code cleaner a tad. Suggested-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> Signed-off-by: Dmitry Osipenko <digetx@gmail.com> --- drivers/input/touchscreen/elants_i2c.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)