diff mbox series

[v9,02/22] media: pvrusb2: Do not check for V4L2_CTRL_WHICH_DEF_VAL

Message ID 20210326095840.364424-3-ribalda@chromium.org
State Accepted
Commit e4ba563d4d4f14c3cda140ae47e0a4e2dcdd639c
Headers show
Series uvcvideo: Fix v4l2-compliance errors | expand

Commit Message

Ricardo Ribalda March 26, 2021, 9:58 a.m. UTC 
The framework already checks for us if V4L2_CTRL_WHICH_DEF_VAL is
written.

Cc: Mike Isely <isely@pobox.com>
Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
Reviewed-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
---
 drivers/media/usb/pvrusb2/pvrusb2-v4l2.c | 4 ----
 1 file changed, 4 deletions(-)

Comments

Laurent Pinchart June 10, 2021, 5:29 p.m. UTC | #1 
Hi Ricardo,

Thank you for the patch.

On Fri, Mar 26, 2021 at 10:58:20AM +0100, Ricardo Ribalda wrote:
> The framework already checks for us if V4L2_CTRL_WHICH_DEF_VAL is

> written.

> 

> Cc: Mike Isely <isely@pobox.com>

> Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>

> Reviewed-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>


Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>


> ---

>  drivers/media/usb/pvrusb2/pvrusb2-v4l2.c | 4 ----

>  1 file changed, 4 deletions(-)

> 

> diff --git a/drivers/media/usb/pvrusb2/pvrusb2-v4l2.c b/drivers/media/usb/pvrusb2/pvrusb2-v4l2.c

> index 9657c1883311..c04ab7258d64 100644

> --- a/drivers/media/usb/pvrusb2/pvrusb2-v4l2.c

> +++ b/drivers/media/usb/pvrusb2/pvrusb2-v4l2.c

> @@ -640,10 +640,6 @@ static int pvr2_s_ext_ctrls(struct file *file, void *priv,

>  	unsigned int idx;

>  	int ret;

>  

> -	/* Default value cannot be changed */

> -	if (ctls->which == V4L2_CTRL_WHICH_DEF_VAL)

> -		return -EINVAL;

> -

>  	ret = 0;

>  	for (idx = 0; idx < ctls->count; idx++) {

>  		ctrl = ctls->controls + idx;


-- 
Regards,

Laurent Pinchart
diff mbox series

Patch

diff --git a/drivers/media/usb/pvrusb2/pvrusb2-v4l2.c b/drivers/media/usb/pvrusb2/pvrusb2-v4l2.c
index 9657c1883311..c04ab7258d64 100644
--- a/drivers/media/usb/pvrusb2/pvrusb2-v4l2.c
+++ b/drivers/media/usb/pvrusb2/pvrusb2-v4l2.c
@@ -640,10 +640,6 @@  static int pvr2_s_ext_ctrls(struct file *file, void *priv,
 	unsigned int idx;
 	int ret;
 
-	/* Default value cannot be changed */
-	if (ctls->which == V4L2_CTRL_WHICH_DEF_VAL)
-		return -EINVAL;
-
 	ret = 0;
 	for (idx = 0; idx < ctls->count; idx++) {
 		ctrl = ctls->controls + idx;