diff mbox series

i2c: stm32f7: Remove useless error message

Message ID 1616673872-4382-1-git-send-email-tiantao6@hisilicon.com
State Accepted
Commit 8f66edb25c4e10f8380c88f4c097158ff611fd10
Headers show
Series i2c: stm32f7: Remove useless error message | expand

Commit Message

Tian Tao March 25, 2021, 12:04 p.m. UTC 
Fix the following coccicheck report:

drivers/i2c/busses/i2c-stm32f7.c:2032:3-10 : platform_get_irq :
line 2032 is redundant because platform_get_irq() already prints an error

Remove dev_err() messages after platform_get_irq() failures.

Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
Signed-off-by: Zihao Tang <tangzihao1@hisilicon.com>
---
 drivers/i2c/busses/i2c-stm32f7.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

Comments

Wolfram Sang March 31, 2021, 7:58 a.m. UTC | #1 
On Thu, Mar 25, 2021 at 08:04:32PM +0800, Tian Tao wrote:
> Fix the following coccicheck report:

> 

> drivers/i2c/busses/i2c-stm32f7.c:2032:3-10 : platform_get_irq :

> line 2032 is redundant because platform_get_irq() already prints an error

> 

> Remove dev_err() messages after platform_get_irq() failures.

> 

> Signed-off-by: Tian Tao <tiantao6@hisilicon.com>

> Signed-off-by: Zihao Tang <tangzihao1@hisilicon.com>


Applied to for-next, thanks!
diff mbox series

Patch

diff --git a/drivers/i2c/busses/i2c-stm32f7.c b/drivers/i2c/busses/i2c-stm32f7.c
index 162a3b0..9fbcbd1 100644
--- a/drivers/i2c/busses/i2c-stm32f7.c
+++ b/drivers/i2c/busses/i2c-stm32f7.c
@@ -2035,12 +2035,8 @@  static int stm32f7_i2c_probe(struct platform_device *pdev)
 	phy_addr = (dma_addr_t)res->start;
 
 	irq_event = platform_get_irq(pdev, 0);
-	if (irq_event <= 0) {
-		if (irq_event != -EPROBE_DEFER)
-			dev_err(&pdev->dev, "Failed to get IRQ event: %d\n",
-				irq_event);
+	if (irq_event <= 0)
 		return irq_event ? : -ENOENT;
-	}
 
 	irq_error = platform_get_irq(pdev, 1);
 	if (irq_error <= 0)