Message ID | 1616745915-194644-1-git-send-email-zhangxuezhi3@gmail.com |
---|---|
State | New |
Headers | show |
Series | staging: fbtft: fix a typo | expand |
On Fri, 26 Mar 2021 09:37:48 +0100 Greg KH <gregkh@linuxfoundation.org> wrote: > On Fri, Mar 26, 2021 at 04:05:15PM +0800, Carlis wrote: > > From: "Carlis" <zhangxuezhi1@yulong.com> > > > > Change 'tft' to 'TFT' > > Why? What is wrong with "tft"? > I think abbreviations should be capitalized. > > > > Signed-off-by: Carlis <zhangxuezhi1@yulong.com> > > Full name please. > OK, i will use my full name next patch > thanks, > > greg k-h
On Fri, 26 Mar 2021 10:33:57 +0100 Greg KH <gregkh@linuxfoundation.org> wrote: > On Fri, Mar 26, 2021 at 05:16:34PM +0800, carlis wrote: > > On Fri, 26 Mar 2021 09:37:48 +0100 > > Greg KH <gregkh@linuxfoundation.org> wrote: > > > > > On Fri, Mar 26, 2021 at 04:05:15PM +0800, Carlis wrote: > > > > From: "Carlis" <zhangxuezhi1@yulong.com> > > > > > > > > Change 'tft' to 'TFT' > > > > > > Why? What is wrong with "tft"? > > > > > I think abbreviations should be capitalized. > > Why? What requires this? Many people use capital letters for abbreviations in comments, which I think is a good practice > > thanks, > > greg k-h thanks, Xuezhi Zhang
diff --git a/drivers/staging/fbtft/fbtft-core.c b/drivers/staging/fbtft/fbtft-core.c index 4f362da..44e7acb 100644 --- a/drivers/staging/fbtft/fbtft-core.c +++ b/drivers/staging/fbtft/fbtft-core.c @@ -775,7 +775,7 @@ void fbtft_framebuffer_release(struct fb_info *info) EXPORT_SYMBOL(fbtft_framebuffer_release); /** - * fbtft_register_framebuffer - registers a tft frame buffer device + * fbtft_register_framebuffer - registers a TFT frame buffer device * @fb_info: frame buffer info structure * * Sets SPI driverdata if needed @@ -873,7 +873,7 @@ int fbtft_register_framebuffer(struct fb_info *fb_info) EXPORT_SYMBOL(fbtft_register_framebuffer); /** - * fbtft_unregister_framebuffer - releases a tft frame buffer device + * fbtft_unregister_framebuffer - releases a TFT frame buffer device * @fb_info: frame buffer info structure * * Frees SPI driverdata if needed