diff mbox series

[next] media: dvb-frontends: Remove redundant error check on variable ret

Message ID 20210323140047.347955-1-colin.king@canonical.com
State Accepted
Commit 7030a96bd99032c4565889082a8ab67db3b62180
Headers show
Series [next] media: dvb-frontends: Remove redundant error check on variable ret | expand

Commit Message

Colin King March 23, 2021, 2 p.m. UTC 
From: Colin Ian King <colin.king@canonical.com>

An earlier commit removed a call to lgdt3306a_spectral_inversion and
omitted to remove the error return check. The check on ret is now
redundant and can be removed.

Addresses-Coverity: ("Logically dead code")
Fixes: d4a3fa6652e3 ("media: dvb-frontends: lgdt3306a.c: remove dead code")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/media/dvb-frontends/lgdt3306a.c | 3 ---
 1 file changed, 3 deletions(-)
diff mbox series

Patch

diff --git a/drivers/media/dvb-frontends/lgdt3306a.c b/drivers/media/dvb-frontends/lgdt3306a.c
index 22d484487695..136b76cb4807 100644
--- a/drivers/media/dvb-frontends/lgdt3306a.c
+++ b/drivers/media/dvb-frontends/lgdt3306a.c
@@ -1017,9 +1017,6 @@  static int lgdt3306a_set_parameters(struct dvb_frontend *fe)
 
 	/* spectral_inversion defaults already set for VSB and QAM */
 
-	if (lg_chkerr(ret))
-		goto fail;
-
 	ret = lgdt3306a_mpeg_mode(state, state->cfg->mpeg_mode);
 	if (lg_chkerr(ret))
 		goto fail;