| Message ID | 1415931040-9868-1-git-send-email-thunder.leizhen@huawei.com |
|---|---|
| State | Accepted |
| Commit | 40ba3f0ff261a14107f3f52c67602fff8b88d980 |
| Headers | show |
Quoting Zhen Lei (2014-11-13 18:10:40) > It's the same to the next statement, "ret = clk->parent". I think compiler will > optimize it, it's just not looking well. > > Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com> Applied. Thanks, Mike > --- > drivers/clk/clk.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c > index 4896ae9..5307225 100644 > --- a/drivers/clk/clk.c > +++ b/drivers/clk/clk.c > @@ -1614,7 +1614,7 @@ static struct clk *__clk_init_parent(struct clk *clk) > > if (clk->num_parents == 1) { > if (IS_ERR_OR_NULL(clk->parent)) > - ret = clk->parent = __clk_lookup(clk->parent_names[0]); > + clk->parent = __clk_lookup(clk->parent_names[0]); > ret = clk->parent; > goto out; > } > -- > 1.8.0 > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c index 4896ae9..5307225 100644 --- a/drivers/clk/clk.c +++ b/drivers/clk/clk.c @@ -1614,7 +1614,7 @@ static struct clk *__clk_init_parent(struct clk *clk) if (clk->num_parents == 1) { if (IS_ERR_OR_NULL(clk->parent)) - ret = clk->parent = __clk_lookup(clk->parent_names[0]); + clk->parent = __clk_lookup(clk->parent_names[0]); ret = clk->parent; goto out; }
It's the same to the next statement, "ret = clk->parent". I think compiler will optimize it, it's just not looking well. Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com> --- drivers/clk/clk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 1.8.0 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/