| Message ID | 20210323135231.24948-5-wangyanan55@huawei.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | KVM: selftests: some improvement and a new test for kvm page table | expand |
On Tue, Mar 23, 2021 at 09:52:25PM +0800, Yanan Wang wrote: > Print the errno besides error-string in TEST_ASSERT in the format of > "errno=%d - %s" will explicitly indicate that the string is an error > information. Besides, the errno is easier to be used for debugging > than the error-string. > > Suggested-by: Andrew Jones <drjones@redhat.com> > Signed-off-by: Yanan Wang <wangyanan55@huawei.com> > --- > tools/testing/selftests/kvm/lib/assert.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/testing/selftests/kvm/lib/assert.c b/tools/testing/selftests/kvm/lib/assert.c > index 5ebbd0d6b472..71ade6100fd3 100644 > --- a/tools/testing/selftests/kvm/lib/assert.c > +++ b/tools/testing/selftests/kvm/lib/assert.c > @@ -71,9 +71,9 @@ test_assert(bool exp, const char *exp_str, > > fprintf(stderr, "==== Test Assertion Failure ====\n" > " %s:%u: %s\n" > - " pid=%d tid=%d - %s\n", > + " pid=%d tid=%d errno=%d - %s\n", > file, line, exp_str, getpid(), _gettid(), > - strerror(errno)); > + errno, strerror(errno)); > test_dump_stack(); > if (fmt) { > fputs(" ", stderr); > -- > 2.19.1 > Reviewed-by: Andrew Jones <drjones@redhat.com>
diff --git a/tools/testing/selftests/kvm/lib/assert.c b/tools/testing/selftests/kvm/lib/assert.c index 5ebbd0d6b472..71ade6100fd3 100644 --- a/tools/testing/selftests/kvm/lib/assert.c +++ b/tools/testing/selftests/kvm/lib/assert.c @@ -71,9 +71,9 @@ test_assert(bool exp, const char *exp_str, fprintf(stderr, "==== Test Assertion Failure ====\n" " %s:%u: %s\n" - " pid=%d tid=%d - %s\n", + " pid=%d tid=%d errno=%d - %s\n", file, line, exp_str, getpid(), _gettid(), - strerror(errno)); + errno, strerror(errno)); test_dump_stack(); if (fmt) { fputs(" ", stderr);
Print the errno besides error-string in TEST_ASSERT in the format of "errno=%d - %s" will explicitly indicate that the string is an error information. Besides, the errno is easier to be used for debugging than the error-string. Suggested-by: Andrew Jones <drjones@redhat.com> Signed-off-by: Yanan Wang <wangyanan55@huawei.com> --- tools/testing/selftests/kvm/lib/assert.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)