| Message ID | 20210320091542.6748-1-hui.wang@canonical.com |
|---|---|
| State | Accepted |
| Commit | febf22565549ea7111e7d45e8f2d64373cc66b11 |
| Headers | show |
| Series | [v3,1/2] ALSA: hda/realtek: fix a determine_headset_type issue for a Dell AIO | expand |
On Sat, 20 Mar 2021 10:15:41 +0100, Hui Wang wrote: > > We found a recording issue on a Dell AIO, users plug a headset-mic and > select headset-mic from UI, but can't record any sound from > headset-mic. The root cause is the determine_headset_type() returns a > wrong type, e.g. users plug a ctia type headset, but that function > returns omtp type. > > On this machine, the internal mic is not connected to the codec, the > "Input Source" is headset mic by default. And when users plug a > headset, the determine_headset_type() will be called immediately, the > codec on this AIO is alc274, the delay time for this codec in the > determine_headset_type() is only 80ms, the delay is too short to > correctly determine the headset type, the fail rate is nearly 99% when > users plug the headset with the normal speed. > > Other codecs set several hundred ms delay time, so here I change the > delay time to 850ms for alc2x4 series, after this change, the fail > rate is zero unless users plug the headset slowly on purpose. > > Cc: <stable@vger.kernel.org> > Signed-off-by: Hui Wang <hui.wang@canonical.com> Applied, thanks. Takashi
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 8239e5efc12d..442e555de44c 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -5263,7 +5263,7 @@ static void alc_determine_headset_type(struct hda_codec *codec) case 0x10ec0274: case 0x10ec0294: alc_process_coef_fw(codec, coef0274); - msleep(80); + msleep(850); val = alc_read_coef_idx(codec, 0x46); is_ctia = (val & 0x00f0) == 0x00f0; break;
We found a recording issue on a Dell AIO, users plug a headset-mic and select headset-mic from UI, but can't record any sound from headset-mic. The root cause is the determine_headset_type() returns a wrong type, e.g. users plug a ctia type headset, but that function returns omtp type. On this machine, the internal mic is not connected to the codec, the "Input Source" is headset mic by default. And when users plug a headset, the determine_headset_type() will be called immediately, the codec on this AIO is alc274, the delay time for this codec in the determine_headset_type() is only 80ms, the delay is too short to correctly determine the headset type, the fail rate is nearly 99% when users plug the headset with the normal speed. Other codecs set several hundred ms delay time, so here I change the delay time to 850ms for alc2x4 series, after this change, the fail rate is zero unless users plug the headset slowly on purpose. Cc: <stable@vger.kernel.org> Signed-off-by: Hui Wang <hui.wang@canonical.com> --- sound/pci/hda/patch_realtek.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)