diff mbox series

Add extra keys for rc6-mce

Message ID 288ddcee-15d1-90b7-8d52-4519faa56ea4@schenkel.net
State New
Headers show
Series Add extra keys for rc6-mce | expand

Commit Message

Leonardo Brondani Schenkel March 17, 2021, 9:59 p.m. UTC 
(This is my first time sending a patch to this project. I hope I'm doing 
it right. This is not necessarily meant to be merged as-is.)

Over the years I have compiled a list of known MCE remote keys from 
multiple sources. Unfortunately I have not written down those sources, 
but I remember that among them there were IR databases such as the one 
from Logitech Harmony, and also some web pages.

I noticed that the RC6-MCE keymap is missing a few of them, so I am 
submitting a patch to include them.

I have a Harmony remote and also a JP1 programmable remote and I 
personally tested all those keys.

I added comments in the diff after the fact to communicate to this list 
what the buttons are on the remote, so you can know why the specific key 
was chosen.
---
  utils/keytable/rc_keymaps/rc6_mce.toml | 8 ++++++++
  1 file changed, 8 insertions(+)

Comments

Leonardo Brondani Schenkel March 18, 2021, 10:37 a.m. UTC | #1 
On 18/03/2021 10.43, Sean Young wrote:
>> I added comments in the diff after the fact to communicate to this list what
>> the buttons are on the remote, so you can know why the specific key was
>> chosen.
> 
> I can't see those comments.

I wasn't very clear. I meant the "#"s, like "# Open/Close".

> Thank you for your patch. These files are generated from the linux kernel
> tree. Your patch should modifiy drivers/media/rc/keymaps/rc-rc6-mce.c,
> and then utils/keytable/rc_keymaps/rc6_mce.toml will be regenerated from
> it.

I noticed the comment on the top of the file. I suspected that I had to 
submit a patch to the kernel instead, but I decided to submit to this 
list first to get that confirmed.

> Many thanks

Thank you.
// Leonardo.
diff mbox series

Patch

diff --git a/utils/keytable/rc_keymaps/rc6_mce.toml 
b/utils/keytable/rc_keymaps/rc6_mce.toml
index 1ee9c722..672fa763 100644
--- a/utils/keytable/rc_keymaps/rc6_mce.toml
+++ b/utils/keytable/rc_keymaps/rc6_mce.toml
@@ -44,24 +44,32 @@  variant = "rc6_mce"
  0x800f0425 = "KEY_TUNER"
  0x800f0426 = "KEY_EPG"
  0x800f0427 = "KEY_ZOOM"
+0x800f0428 = "KEY_OPEN" # Open/Close
+0x800f0429 = "KEY_WAKEUP" # Power on (discrete)
+0x800f042a = "KEY_SLEEP" # Power off (discrete)
  0x800f0432 = "KEY_MODE"
  0x800f0433 = "KEY_PRESENTATION"
  0x800f0434 = "KEY_EJECTCD"
  0x800f043a = "KEY_BRIGHTNESSUP"
+0x800f043b = "KEY_EXIT" # Exit/Close (Alt+F4 in Windows)
  0x800f0446 = "KEY_TV"
  0x800f0447 = "KEY_AUDIO"
  0x800f0448 = "KEY_PVR"
  0x800f0449 = "KEY_CAMERA"
  0x800f044a = "KEY_VIDEO"
+0x800f044b = "KEY_ANGLE" # DVD angle
  0x800f044c = "KEY_LANGUAGE"
  0x800f044d = "KEY_TITLE"
  0x800f044e = "KEY_PRINT"
+0x800f044f = "KEY_DISPLAYTOGGLE" # Display
  0x800f0450 = "KEY_RADIO"
+0x800f0451 = "KEY_TITLE" # Title
  0x800f045a = "KEY_SUBTITLE"
  0x800f045b = "KEY_RED"
  0x800f045c = "KEY_GREEN"
  0x800f045d = "KEY_YELLOW"
  0x800f045e = "KEY_BLUE"
+0x800f0464 = "KEY_GAMES" # Xbox
  0x800f0465 = "KEY_POWER2"
  0x800f0469 = "KEY_MESSENGER"
  0x800f046e = "KEY_PLAYPAUSE"