| Message ID | 20210315120937.2512341-5-bryan.odonoghue@linaro.org |
|---|---|
| State | Superseded |
| Headers | show
Delivered-To: patch@linaro.org Received: by 2002:a02:8562:0:0:0:0:0 with SMTP id g89csp3356553jai; Mon, 15 Mar 2021 05:09:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxtFP353vVtnIZc/D4/PS91dLbopsh9eExkHKzrKVpA7zPHv+EshuljfayPQf/7EFS1CvVe X-Received: by 2002:adf:f083:: with SMTP id n3mr26370354wro.134.1615810150423; Mon, 15 Mar 2021 05:09:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1615810150; cv=none; d=google.com; s=arc-20160816; b=G0mrExqdMPUhH3t0mC0xGLMQ9QxcmvoPchSHvmO7X55Kawt6ui/DsCzH2oxh1wXsYR PCvNvlDLHCDMlCGUHhxLZ/jX9cvCtPYPqKizRtFK9quBfJsPtibvfyvUqy/l+9SxMzzr CX6fnrg1nDLOZgKBrCauLRFrDh+bHSg8s9EGav7hlW3kEzl6gQOuHaBb6Du3QUzVwY+H SsOYDK0RFy63CbBchnwCwg79yrhS8wfK/IJezI7n06KcSJdAxcZ+DxFctTdn3c9d+Uqi EfMi6wjwpjlSkgki0FBLqh9S5yHNPbu+BT1QRquoUZ/EQQObJDRlB25RTqGdlXt6qmcY 6SXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=PK1ysPzp6vM3CYkwLCzyPDUUfmW5NdD9G7dghbyOwwQ=; b=Pm0dEfBaRRppEKJFXcPs3HvMqbFthO0h3XsNbERMefAWgT5UFx1dfqyZXlSTinltjn 5A2QUTMXPj6vc1sRQuFMHWsHj5oKMvRQilrI9gL6WBuLDAPVsKpsTgjJe+sJWKSml8h1 dxKdeKzLU7EPr5cvW+cb6E0usN9NElpMD2+pBd24RKoWI+Oegi1iLvPkQaU5K/r/D7Qp G1zO5oFUdqvH0Pvx/jzoHKojldux3t02o7T/ZdIVLEb2MuHj2JSvwvD6nK3r/o2/Mrt0 TLamLZ7R+o9r/1dntRv3tFJT7xXwtzaNGB6FhE275uTdBQ8aTa5Eypy8/+qGbyqiYSj1 bOzg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Dn2aLoSl; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: <linux-wireless-owner@vger.kernel.org> Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g8si9901547wmk.85.2021.03.15.05.09.10; Mon, 15 Mar 2021 05:09:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Dn2aLoSl; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231131AbhCOMIi (ORCPT <rfc822;patch@linaro.org> + 2 others); Mon, 15 Mar 2021 08:08:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48786 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230453AbhCOMIO (ORCPT <rfc822;linux-wireless@vger.kernel.org>); Mon, 15 Mar 2021 08:08:14 -0400 Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D33DAC061574 for <linux-wireless@vger.kernel.org>; Mon, 15 Mar 2021 05:08:13 -0700 (PDT) Received: by mail-wm1-x32e.google.com with SMTP id g8so7978021wmd.4 for <linux-wireless@vger.kernel.org>; Mon, 15 Mar 2021 05:08:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=PK1ysPzp6vM3CYkwLCzyPDUUfmW5NdD9G7dghbyOwwQ=; b=Dn2aLoSlYFaM1HqnkLdAGbnG612XxzqF/xX71Q5KWCoYaQx4klRO6lfxideNihhAgO ltim+K8CNj1Qa1daR7Vt2rvE9vx7OwOxiRruuRO5Oqrg6ARbdnzYQcsT90hJPaI93MR4 7MUGfI8A4ni3dEOlQbszOkGKD3EY+f68/18Ggr5XGn4tlSIdyM1IhK+hQnWqz7Uqmo6A oITYXD3/BztB8ge/QFeqcJ0VOZCQ4INi9ApBx+sFRQpWs0TXs0gYrX5gMx0Imb33ENCW buFIkYEEmcK+Q9ACDHFB/k7mRMdo8if11bNGcL6zDFn3BndMeSUH0RbjrK+SG6539Ghu mbeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=PK1ysPzp6vM3CYkwLCzyPDUUfmW5NdD9G7dghbyOwwQ=; b=Xfpm68dIDSmXhH1nReKasabeXJaCaO8wCMrrmIyxn01nIXuJ/JIzw1hzoBfh9gmWK3 Mfd7tv1pDM5byLdspCu4M6qKGxAZYKG3sr+VDKLflIdCh8GTnBvrVVF7QNdyJOW+aQvS Vh+7h1mb9t2bKmc49QiFby0tRgfCKSw9D0oOvEDTkymB1LlnJsa2ONdx4MXyHL6Pvvps zU4k+zj7yQuKpWn8f8m7M1lApqEVkJapLEXYP3538P0/bLqEgAMsGVe4aJ0a1kL0aSm8 REQVqXEZDigXk1paTPjVD+ZXVFik6SAiPr2v/uJqPXZwND2YSyWq0/OTLoFRwxzuWa5k fXUw== X-Gm-Message-State: AOAM5321ljHP4yvfyJ75OOjEgyx0GV08E7h47cSrVznD9z0XDVgGVAtk uVDLcFWbQUvGuebK2GCSXzmhVg== X-Received: by 2002:a1c:195:: with SMTP id 143mr26052009wmb.147.1615810092491; Mon, 15 Mar 2021 05:08:12 -0700 (PDT) Received: from sagittarius-a.chello.ie (188-141-3-169.dynamic.upc.ie. [188.141.3.169]) by smtp.gmail.com with ESMTPSA id c18sm29239891wmk.0.2021.03.15.05.08.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Mar 2021 05:08:12 -0700 (PDT) From: Bryan O'Donoghue <bryan.odonoghue@linaro.org> To: kvalo@codeaurora.org, wcn36xx@lists.infradead.org, linux-wireless@vger.kernel.org Cc: bryan.odonoghue@linaro.org, shawn.guo@linaro.org, benl@squareup.com, loic.poulain@linaro.org, bjorn.andersson@linaro.org Subject: [PATCH v2 04/12] wcn36xx: Do not flush indication queue on suspend/resume Date: Mon, 15 Mar 2021 12:09:29 +0000 Message-Id: <20210315120937.2512341-5-bryan.odonoghue@linaro.org> X-Mailer: git-send-email 2.30.1 In-Reply-To: <20210315120937.2512341-1-bryan.odonoghue@linaro.org> References: <20210315120937.2512341-1-bryan.odonoghue@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: <linux-wireless.vger.kernel.org> X-Mailing-List: linux-wireless@vger.kernel.org |
| Series |
wcn36xx: Enable downstream consistent Wake on Lan
|
expand
|
diff --git a/drivers/net/wireless/ath/wcn36xx/main.c b/drivers/net/wireless/ath/wcn36xx/main.c index f95103706100..029c9952b4fb 100644 --- a/drivers/net/wireless/ath/wcn36xx/main.c +++ b/drivers/net/wireless/ath/wcn36xx/main.c @@ -1110,7 +1110,6 @@ static int wcn36xx_suspend(struct ieee80211_hw *hw, struct cfg80211_wowlan *wow) wcn36xx_dbg(WCN36XX_DBG_MAC, "mac suspend\n"); - flush_workqueue(wcn->hal_ind_wq); mutex_lock(&wcn->conf_mutex); vif = wcn36xx_get_first_vif(wcn); if (vif) { @@ -1135,7 +1134,6 @@ static int wcn36xx_resume(struct ieee80211_hw *hw) wcn36xx_dbg(WCN36XX_DBG_MAC, "mac resume\n"); - flush_workqueue(wcn->hal_ind_wq); mutex_lock(&wcn->conf_mutex); vif = wcn36xx_get_first_vif(wcn); if (vif) {
Testing on Android reveals that the flush on both suspend and resume of the firmware indication work-queue can stall indefinitely. Given this code path doesn't appear to have been exercised up until now, removing this flush to unblock this situation. Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> --- drivers/net/wireless/ath/wcn36xx/main.c | 2 -- 1 file changed, 2 deletions(-) -- 2.30.1