| Message ID | 1414651017-3545-6-git-send-email-sbranden@broadcom.com |
|---|---|
| State | New |
| Headers | show |
On 10/30/2014 12:36 AM, Scott Branden wrote:
> SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12 is missing and needed for this controller.
This seems fine, although any explanation of why this quirk is needed
would be useful.
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On 14-11-04 09:00 PM, Stephen Warren wrote: > On 10/30/2014 12:36 AM, Scott Branden wrote: >> SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12 is missing and needed for this controller. > > This seems fine, although any explanation of why this quirk is needed > would be useful. > I don't know who to talk to at Arasan about this. Will try hunting around a little for more info as to why this is needed to have eMMC and SD work properly through our internal testing on other non-2835 chipset that shares the same SDHCI controller as 2835. -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 11/05/2014 12:02 AM, Scott Branden wrote: > On 14-11-04 09:00 PM, Stephen Warren wrote: >> On 10/30/2014 12:36 AM, Scott Branden wrote: >>> SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12 is missing and needed for this >>> controller. >> >> This seems fine, although any explanation of why this quirk is needed >> would be useful. >> > I don't know who to talk to at Arasan about this. Will try hunting > around a little for more info as to why this is needed to have eMMC and > SD work properly through our internal testing on other non-2835 chipset > that shares the same SDHCI controller as 2835. I thought I heard that this wasn't a bug in the controller itself, but rather an integration issue between the IP core and the register bus it's attached to. Consequently, it may be SoC-specific or at least have SoC-specific variations? -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 14-11-05 08:50 PM, Stephen Warren wrote: > On 11/05/2014 12:02 AM, Scott Branden wrote: >> On 14-11-04 09:00 PM, Stephen Warren wrote: >>> On 10/30/2014 12:36 AM, Scott Branden wrote: >>>> SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12 is missing and needed for this >>>> controller. >>> >>> This seems fine, although any explanation of why this quirk is needed >>> would be useful. >>> >> I don't know who to talk to at Arasan about this. Will try hunting >> around a little for more info as to why this is needed to have eMMC and >> SD work properly through our internal testing on other non-2835 chipset >> that shares the same SDHCI controller as 2835. > > I thought I heard that this wasn't a bug in the controller itself, but > rather an integration issue between the IP core and the register bus > it's attached to. Consequently, it may be SoC-specific or at least have > SoC-specific variations? Yes, this patch is to fix a different bug (in the IP) rather than the clock domain integration issue. > -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/mmc/host/sdhci-bcm2835.c b/drivers/mmc/host/sdhci-bcm2835.c index 11af27f..2a4c10b 100644 --- a/drivers/mmc/host/sdhci-bcm2835.c +++ b/drivers/mmc/host/sdhci-bcm2835.c @@ -159,7 +159,8 @@ static const struct sdhci_ops bcm2835_sdhci_ops = { }; static const struct sdhci_pltfm_data bcm2835_sdhci_pdata = { - .quirks = SDHCI_QUIRK_BROKEN_CARD_DETECTION | + .quirks = SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12 | + SDHCI_QUIRK_BROKEN_CARD_DETECTION | SDHCI_QUIRK_DATA_TIMEOUT_USES_SDCLK, .ops = &bcm2835_sdhci_ops, };
SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12 is missing and needed for this controller. Signed-off-by: Scott Branden <sbranden@broadcom.com> --- drivers/mmc/host/sdhci-bcm2835.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)