| Message ID | 1414589046-16214-2-git-send-email-zoltan.kiss@linaro.org |
|---|---|
| State | New |
| Headers | show |
On Wed, Oct 29, 2014 at 3:24 PM, Zoltan Kiss <zoltan.kiss@linaro.org> wrote: > An empty parameter list is not very standard, better specify it explicitly. You mean the parameter list for odp_init_global? It's not empty in last ODP version, you have to specify it. > > Signed-off-by: Zoltan Kiss <zoltan.kiss@linaro.org> > --- > acinclude.m4 | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/acinclude.m4 b/acinclude.m4 > index 09295d2..68f49b7 100644 > --- a/acinclude.m4 > +++ b/acinclude.m4 > @@ -294,7 +294,7 @@ AC_DEFUN([OVS_CHECK_ODP], [ > LIBS="-lodp $extras $save_LIBS" > AC_LINK_IFELSE( > [AC_LANG_PROGRAM([#include <odp.h>], > - [odp_init_global();])], > + [odp_init_global(NULL, NULL);])], > [found=true]) > if $found; then > break > -- > 1.9.1 >
On 30/10/14 11:17, Ciprian Barbu wrote: > On Wed, Oct 29, 2014 at 3:24 PM, Zoltan Kiss <zoltan.kiss@linaro.org> wrote: >> An empty parameter list is not very standard, better specify it explicitly. > > You mean the parameter list for odp_init_global? It's not empty in > last ODP version, you have to specify it. Yes, I meant that :) Reading it again, my commit message is absolutely rubbish, please ignore it. Here is a better one: The init function now has parameters, pass NULL pointers for the linking test. > >> >> Signed-off-by: Zoltan Kiss <zoltan.kiss@linaro.org> >> --- >> acinclude.m4 | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/acinclude.m4 b/acinclude.m4 >> index 09295d2..68f49b7 100644 >> --- a/acinclude.m4 >> +++ b/acinclude.m4 >> @@ -294,7 +294,7 @@ AC_DEFUN([OVS_CHECK_ODP], [ >> LIBS="-lodp $extras $save_LIBS" >> AC_LINK_IFELSE( >> [AC_LANG_PROGRAM([#include <odp.h>], >> - [odp_init_global();])], >> + [odp_init_global(NULL, NULL);])], >> [found=true]) >> if $found; then >> break >> -- >> 1.9.1 >>
On Thu, Oct 30, 2014 at 1:48 PM, Zoltan Kiss <zoltan.kiss@linaro.org> wrote: > > > On 30/10/14 11:17, Ciprian Barbu wrote: >> >> On Wed, Oct 29, 2014 at 3:24 PM, Zoltan Kiss <zoltan.kiss@linaro.org> >> wrote: >>> >>> An empty parameter list is not very standard, better specify it >>> explicitly. >> >> >> You mean the parameter list for odp_init_global? It's not empty in >> last ODP version, you have to specify it. > > Yes, I meant that :) Reading it again, my commit message is absolutely > rubbish, please ignore it. Here is a better one: > The init function now has parameters, pass NULL pointers for the linking > test. Sounds much better :) > >> >>> >>> Signed-off-by: Zoltan Kiss <zoltan.kiss@linaro.org> >>> --- >>> acinclude.m4 | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/acinclude.m4 b/acinclude.m4 >>> index 09295d2..68f49b7 100644 >>> --- a/acinclude.m4 >>> +++ b/acinclude.m4 >>> @@ -294,7 +294,7 @@ AC_DEFUN([OVS_CHECK_ODP], [ >>> LIBS="-lodp $extras $save_LIBS" >>> AC_LINK_IFELSE( >>> [AC_LANG_PROGRAM([#include <odp.h>], >>> - [odp_init_global();])], >>> + [odp_init_global(NULL, NULL);])], >>> [found=true]) >>> if $found; then >>> break >>> -- >>> 1.9.1 >>> >
diff --git a/acinclude.m4 b/acinclude.m4 index 09295d2..68f49b7 100644 --- a/acinclude.m4 +++ b/acinclude.m4 @@ -294,7 +294,7 @@ AC_DEFUN([OVS_CHECK_ODP], [ LIBS="-lodp $extras $save_LIBS" AC_LINK_IFELSE( [AC_LANG_PROGRAM([#include <odp.h>], - [odp_init_global();])], + [odp_init_global(NULL, NULL);])], [found=true]) if $found; then break
An empty parameter list is not very standard, better specify it explicitly. Signed-off-by: Zoltan Kiss <zoltan.kiss@linaro.org> --- acinclude.m4 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)