| Message ID | 1414525992-3678-9-git-send-email-sbranden@broadcom.com |
|---|---|
| State | New |
| Headers | show |
On Tuesday 28 October 2014 12:53:12 Scott Branden wrote: > From: Ray Jui <rjui@broadcom.com> > > Enable Broadcom Cygnus platform support in multi_v7_defconfig > > Signed-off-by: Ray Jui <rjui@broadcom.com> > Signed-off-by: Scott Branden <sbranden@broadcom.com> > Just to be sure: did you check that multi_v7_defconfig contains all the drivers you need that you enable in your other defconfig? Arnd -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 14-10-28 01:01 PM, Arnd Bergmann wrote: > On Tuesday 28 October 2014 12:53:12 Scott Branden wrote: >> From: Ray Jui <rjui@broadcom.com> >> >> Enable Broadcom Cygnus platform support in multi_v7_defconfig >> >> Signed-off-by: Ray Jui <rjui@broadcom.com> >> Signed-off-by: Scott Branden <sbranden@broadcom.com> >> > > Just to be sure: did you check that multi_v7_defconfig contains > all the drivers you need that you enable in your other defconfig? No - the other defconfig has more that have not been tested on the device. The defconfig builds, but the other drivers haven't been tested. I guess we can try adding them to the multi_defconfig right now as well or wait until we have tested them? There will need to be addition dts changes in the future after we have tested the other drivers. Can we wait to add them to multi_v7_defconfig or do you want them in this patchset? > > Arnd > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tuesday 28 October 2014 13:06:28 Scott Branden wrote: > On 14-10-28 01:01 PM, Arnd Bergmann wrote: > > On Tuesday 28 October 2014 12:53:12 Scott Branden wrote: > >> From: Ray Jui <rjui@broadcom.com> > >> > >> Enable Broadcom Cygnus platform support in multi_v7_defconfig > >> > >> Signed-off-by: Ray Jui <rjui@broadcom.com> > >> Signed-off-by: Scott Branden <sbranden@broadcom.com> > >> > > > > Just to be sure: did you check that multi_v7_defconfig contains > > all the drivers you need that you enable in your other defconfig? > No - the other defconfig has more that have not been tested on the > device. The defconfig builds, but the other drivers haven't been > tested. I guess we can try adding them to the multi_defconfig right now > as well or wait until we have tested them? There will need to be > addition dts changes in the future after we have tested the other drivers. > > Can we wait to add them to multi_v7_defconfig or do you want them in > this patchset? The important part is that you don't break other platforms, and that is independent of whether the code actually does the right thing. If you know that you will need certain drivers to make use of the platform, just enable them now. Arnd -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig index 6e0d7cb..c223da3 100644 --- a/arch/arm/configs/multi_v7_defconfig +++ b/arch/arm/configs/multi_v7_defconfig @@ -17,6 +17,7 @@ CONFIG_MACH_ARMADA_38X=y CONFIG_MACH_ARMADA_XP=y CONFIG_MACH_DOVE=y CONFIG_ARCH_BCM=y +CONFIG_ARCH_BCM_CYGNUS=y CONFIG_ARCH_BCM_21664=y CONFIG_ARCH_BCM_281XX=y CONFIG_ARCH_BCM_5301X=y