| Message ID | 20210308224228.344888-1-luiz.dentz@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v2] monitor: Fix invalid access | expand |
Hi, On Mon, Mar 8, 2021 at 3:00 PM <bluez.test.bot@gmail.com> wrote: > > This is automated email and please do not reply to this email! > > Dear submitter, > > Thank you for submitting the patches to the linux bluetooth mailing list. > This is a CI test results with your patch series: > PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=444125 > > ---Test result--- > > ############################## > Test: CheckPatch - PASS > > ############################## > Test: CheckGitLint - PASS > > ############################## > Test: CheckBuild - PASS > > ############################## > Test: MakeCheck - PASS > > > > --- > Regards, > Linux Bluetooth Pushed.
diff --git a/monitor/packet.c b/monitor/packet.c index a72b424fe..8b87d3d8b 100644 --- a/monitor/packet.c +++ b/monitor/packet.c @@ -11306,7 +11306,7 @@ void packet_user_logging(struct timeval *tv, struct ucred *cred, label = "Message"; } - if (ident[0] == '<' || ident[0] == '>') { + if (ident && (ident[0] == '<' || ident[0] == '>')) { packet_decode(tv, cred, ident[0], index, color, label == ident ? &ident[2] : label, data, size);
From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com> ident can be NULL when printing user logs which may lead ot invalid access. Fixes: https://github.com/bluez/bluez/issues/92 --- monitor/packet.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)