| Message ID | 20210306014127.850411-1-andrii@kernel.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [bpf-next] libbpf: fix INSTALL flag order | expand |
Hello: This patch was applied to bpf/bpf.git (refs/heads/master): On Fri, 5 Mar 2021 17:41:26 -0800 you wrote: > It was reported ([0]) that having optional -m flag between source and > destination arguments in install command breaks bpftools cross-build on MacOS. > Move -m to the front to fix this issue. > > [0] https://github.com/openwrt/openwrt/pull/3959 > > Fixes: 7110d80d53f4 ("libbpf: Makefile set specified permission mode") > Reported-by: Georgi Valkov <gvalkov@abv.bg> > Signed-off-by: Andrii Nakryiko <andrii@kernel.org> > > [...] Here is the summary with links: - [bpf-next] libbpf: fix INSTALL flag order https://git.kernel.org/bpf/bpf/c/e7fb6465d4c8 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/tools/lib/bpf/Makefile b/tools/lib/bpf/Makefile index 8170f88e8ea6..87b14b74d62f 100644 --- a/tools/lib/bpf/Makefile +++ b/tools/lib/bpf/Makefile @@ -215,7 +215,7 @@ define do_install if [ ! -d '$(DESTDIR_SQ)$2' ]; then \ $(INSTALL) -d -m 755 '$(DESTDIR_SQ)$2'; \ fi; \ - $(INSTALL) $1 $(if $3,-m $3,) '$(DESTDIR_SQ)$2' + $(INSTALL) $(if $3,-m $3,) $1 '$(DESTDIR_SQ)$2' endef install_lib: all_cmd
It was reported ([0]) that having optional -m flag between source and destination arguments in install command breaks bpftools cross-build on MacOS. Move -m to the front to fix this issue. [0] https://github.com/openwrt/openwrt/pull/3959 Fixes: 7110d80d53f4 ("libbpf: Makefile set specified permission mode") Reported-by: Georgi Valkov <gvalkov@abv.bg> Signed-off-by: Andrii Nakryiko <andrii@kernel.org> --- tools/lib/bpf/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)