| Message ID | 1413869244-19751-1-git-send-email-bala.manoharan@linaro.org |
|---|---|
| State | New |
| Headers | show |
On Tue, Oct 21, 2014 at 12:27 AM, Balasubramanian Manoharan < bala.manoharan@linaro.org> wrote: > Signed-off-by: Balasubramanian Manoharan <bala.manoharan@linaro.org> > Reviewed-by: Bill Fischofer <bill.fischofer@linaro.org> > --- > Removes struct definition from platform specific opaque handles > Corrects variable definition in odp_pktio_pmr_match_set_cos and > odp_pmr_match_set_create function > classification_design.dox | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/classification_design.dox b/classification_design.dox > index 58d55a1..827fe58 100644 > --- a/classification_design.dox > +++ b/classification_design.dox > @@ -143,7 +143,7 @@ The names are part of the ODP API and MUST be present > in any conforming implemen > /** > * Class of service instance type > */ > -typedef uint32_t odp_cos_t; > +typedef <implementation-definition> odp_cos_t; > > > /** > @@ -518,7 +518,7 @@ The following data structures SHOULD be implemented to > support the definition of > > > #define ODP_PMR_INVAL ((odp_pmr_t)NULL) > -typedef struct odp_pmr_s *odp_pmr_t; > +typedef <implementation-definition> odp_pmr_t; > @endverbatim > > @subsection terms Terms > @@ -765,7 +765,7 @@ typedef struct odp_pmr_match_t { > > > /** An opaque handle to a composite packet match rule-set */ > -typedef struct odp_pmr_set_s *odp_pmr_set_t; > +typedef <implementation-definition> odp_pmr_set_t; > @endverbatim > > The above structure is used with the following APIs to implement > table-based PMRs: > @@ -790,7 +790,7 @@ The above structure is used with the following APIs to > implement table-based PMR > */ > > int odp_pmr_match_set_create(int num_terms, odp_pmr_match_t *terms, > - odp_pmr_set_t *pmr_set_id); > + odp_cos_t dst_cos, odp_pmr_set_t > *pmr_set_id); > @endverbatim > > This routine is used to create a PMR match set. > @@ -830,7 +830,7 @@ This routine destroys a PMR match set previously > created by odp_pmr_match_set_cr > * @return Success or ODP_PARAMETER_ERROR > */ > > -int odp_pktio_pmr_match_set_cos(odp_pmr_t pmr_id, odp_pktio_t src_pktio, > +int odp_pktio_pmr_match_set_cos(odp_pmr_set_t pmr_set_id, odp_pktio_t > src_pktio, > odp_cos_t dst_cos); > @endverbatim > > -- > 2.0.1.472.g6f92e5f > > > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org > http://lists.linaro.org/mailman/listinfo/lng-odp >
On 2014-10-21 10:57, Balasubramanian Manoharan wrote: > Signed-off-by: Balasubramanian Manoharan <bala.manoharan@linaro.org> > --- > Removes struct definition from platform specific opaque handles > Corrects variable definition in odp_pktio_pmr_match_set_cos and > odp_pmr_match_set_create function > classification_design.dox | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/classification_design.dox b/classification_design.dox > index 58d55a1..827fe58 100644 > --- a/classification_design.dox > +++ b/classification_design.dox > @@ -143,7 +143,7 @@ The names are part of the ODP API and MUST be present in any conforming implemen > /** > * Class of service instance type > */ > -typedef uint32_t odp_cos_t; > +typedef <implementation-definition> odp_cos_t; > > > /** > @@ -518,7 +518,7 @@ The following data structures SHOULD be implemented to support the definition of > > > #define ODP_PMR_INVAL ((odp_pmr_t)NULL) > -typedef struct odp_pmr_s *odp_pmr_t; > +typedef <implementation-definition> odp_pmr_t; > @endverbatim > > @subsection terms Terms > @@ -765,7 +765,7 @@ typedef struct odp_pmr_match_t { > > > /** An opaque handle to a composite packet match rule-set */ > -typedef struct odp_pmr_set_s *odp_pmr_set_t; > +typedef <implementation-definition> odp_pmr_set_t; > @endverbatim > > The above structure is used with the following APIs to implement table-based PMRs: > @@ -790,7 +790,7 @@ The above structure is used with the following APIs to implement table-based PMR > */ > > int odp_pmr_match_set_create(int num_terms, odp_pmr_match_t *terms, > - odp_pmr_set_t *pmr_set_id); > + odp_cos_t dst_cos, odp_pmr_set_t *pmr_set_id); > @endverbatim > > This routine is used to create a PMR match set. > @@ -830,7 +830,7 @@ This routine destroys a PMR match set previously created by odp_pmr_match_set_cr > * @return Success or ODP_PARAMETER_ERROR > */ > > -int odp_pktio_pmr_match_set_cos(odp_pmr_t pmr_id, odp_pktio_t src_pktio, > +int odp_pktio_pmr_match_set_cos(odp_pmr_set_t pmr_set_id, odp_pktio_t src_pktio, > odp_cos_t dst_cos); > @endverbatim > > -- > 2.0.1.472.g6f92e5f > > > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org > http://lists.linaro.org/mailman/listinfo/lng-odp Applied, thanks.
diff --git a/classification_design.dox b/classification_design.dox index 58d55a1..827fe58 100644 --- a/classification_design.dox +++ b/classification_design.dox @@ -143,7 +143,7 @@ The names are part of the ODP API and MUST be present in any conforming implemen /** * Class of service instance type */ -typedef uint32_t odp_cos_t; +typedef <implementation-definition> odp_cos_t; /** @@ -518,7 +518,7 @@ The following data structures SHOULD be implemented to support the definition of #define ODP_PMR_INVAL ((odp_pmr_t)NULL) -typedef struct odp_pmr_s *odp_pmr_t; +typedef <implementation-definition> odp_pmr_t; @endverbatim @subsection terms Terms @@ -765,7 +765,7 @@ typedef struct odp_pmr_match_t { /** An opaque handle to a composite packet match rule-set */ -typedef struct odp_pmr_set_s *odp_pmr_set_t; +typedef <implementation-definition> odp_pmr_set_t; @endverbatim The above structure is used with the following APIs to implement table-based PMRs: @@ -790,7 +790,7 @@ The above structure is used with the following APIs to implement table-based PMR */ int odp_pmr_match_set_create(int num_terms, odp_pmr_match_t *terms, - odp_pmr_set_t *pmr_set_id); + odp_cos_t dst_cos, odp_pmr_set_t *pmr_set_id); @endverbatim This routine is used to create a PMR match set. @@ -830,7 +830,7 @@ This routine destroys a PMR match set previously created by odp_pmr_match_set_cr * @return Success or ODP_PARAMETER_ERROR */ -int odp_pktio_pmr_match_set_cos(odp_pmr_t pmr_id, odp_pktio_t src_pktio, +int odp_pktio_pmr_match_set_cos(odp_pmr_set_t pmr_set_id, odp_pktio_t src_pktio, odp_cos_t dst_cos); @endverbatim
Signed-off-by: Balasubramanian Manoharan <bala.manoharan@linaro.org> --- Removes struct definition from platform specific opaque handles Corrects variable definition in odp_pktio_pmr_match_set_cos and odp_pmr_match_set_create function classification_design.dox | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)