diff mbox series

drivers: input: joystick: fix Kconfig dependency on IIO_BUFFER

Message ID 20210225062602.13236-1-julianbraha@gmail.com
State New
Headers show
Series drivers: input: joystick: fix Kconfig dependency on IIO_BUFFER | expand

Commit Message

Julian Braha Feb. 25, 2021, 6:26 a.m. UTC
When JOYSTICK_ADC is enabled, and IIO_BUFFER is disabled,
Kbuild gives the following warning:

WARNING: unmet direct dependencies detected for IIO_BUFFER_CB
  Depends on [n]: IIO [=y] && IIO_BUFFER [=n]
  Selected by [y]:
  - JOYSTICK_ADC [=y] && !UML && INPUT [=y] && INPUT_JOYSTICK [=y] && IIO [=y]

This is because JOYSTICK_ADC selects IIO_BUFFER_CB
without selecting or depending on IIO_BUFFER,
despite IIO_BUFFER_CB depending on IIO_BUFFER.

Signed-off-by: Julian Braha <julianbraha@gmail.com>
---
 drivers/input/joystick/Kconfig | 1 +
 1 file changed, 1 insertion(+)
diff mbox series

Patch

diff --git a/drivers/input/joystick/Kconfig b/drivers/input/joystick/Kconfig
index 5e38899058c1..3c169b86c977 100644
--- a/drivers/input/joystick/Kconfig
+++ b/drivers/input/joystick/Kconfig
@@ -45,6 +45,7 @@  config JOYSTICK_A3D
 config JOYSTICK_ADC
 	tristate "Simple joystick connected over ADC"
 	depends on IIO
+	select IIO_BUFFER
 	select IIO_BUFFER_CB
 	help
 	  Say Y here if you have a simple joystick connected over ADC.