diff mbox series

iwlwifi: fix link error without CONFIG_IWLMVM

Message ID 20210225143236.3543360-1-arnd@kernel.org
State New
Headers show
Series iwlwifi: fix link error without CONFIG_IWLMVM | expand

Commit Message

Arnd Bergmann Feb. 25, 2021, 2:30 p.m. UTC 
From: Arnd Bergmann <arnd@arndb.de>


A runtime check that was introduced recently failed to
check for the matching Kconfig symbol:

ld.lld: error: undefined symbol: iwl_so_trans_cfg
>>> referenced by drv.c

>>>               net/wireless/intel/iwlwifi/pcie/drv.o:(iwl_pci_probe)


Fixes: 930be4e76f26 ("iwlwifi: add support for SnJ with Jf devices")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>

---
 drivers/net/wireless/intel/iwlwifi/pcie/drv.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

-- 
2.29.2

Comments

Kalle Valo Feb. 25, 2021, 6:21 p.m. UTC | #1 
Arnd Bergmann <arnd@kernel.org> writes:

> From: Arnd Bergmann <arnd@arndb.de>

>

> A runtime check that was introduced recently failed to

> check for the matching Kconfig symbol:

>

> ld.lld: error: undefined symbol: iwl_so_trans_cfg

>>>> referenced by drv.c

>>>>               net/wireless/intel/iwlwifi/pcie/drv.o:(iwl_pci_probe)

>

> Fixes: 930be4e76f26 ("iwlwifi: add support for SnJ with Jf devices")

> Signed-off-by: Arnd Bergmann <arnd@arndb.de>


A sent a similar patch this morning:

https://patchwork.kernel.org/project/linux-wireless/patch/1614236661-20274-1-git-send-email-kvalo@codeaurora.org/

But I forgot to include an Fixes tag, I'll add that to my patch during commit.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
diff mbox series

Patch

diff --git a/drivers/net/wireless/intel/iwlwifi/pcie/drv.c b/drivers/net/wireless/intel/iwlwifi/pcie/drv.c
index 314fec4a89ad..a2f5c4fc2324 100644
--- a/drivers/net/wireless/intel/iwlwifi/pcie/drv.c
+++ b/drivers/net/wireless/intel/iwlwifi/pcie/drv.c
@@ -1113,7 +1113,8 @@  static int iwl_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
 	 * here.  But if we detect that the MAC type is actually SnJ,
 	 * we should switch to it here to avoid problems later.
 	 */
-	if (CSR_HW_REV_TYPE(iwl_trans->hw_rev) == IWL_CFG_MAC_TYPE_SNJ)
+	if (IS_ENABLED(CONFIG_IWLMVM) &&
+	    CSR_HW_REV_TYPE(iwl_trans->hw_rev) == IWL_CFG_MAC_TYPE_SNJ)
 		iwl_trans->trans_cfg = &iwl_so_trans_cfg;
 
 #if IS_ENABLED(CONFIG_IWLMVM)