| Message ID | 1614156520-105525-1-git-send-email-yang.lee@linux.alibaba.com |
|---|---|
| State | New |
| Headers | show |
| Series | PM: AVS: Replace DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS_ATTRIBUTE | expand |
On 16:48-20210224, Yang Li wrote: > Fix the following coccicheck warning: > ./drivers/soc/ti/smartreflex.c:820:0-23: WARNING: pm_sr_fops should be > defined with DEFINE_DEBUGFS_ATTRIBUTE > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> > --- > drivers/soc/ti/smartreflex.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/soc/ti/smartreflex.c b/drivers/soc/ti/smartreflex.c > index 5376f3d..b3c7460 100644 > --- a/drivers/soc/ti/smartreflex.c > +++ b/drivers/soc/ti/smartreflex.c > @@ -817,7 +817,7 @@ static int omap_sr_autocomp_store(void *data, u64 val) > return 0; > } > > -DEFINE_SIMPLE_ATTRIBUTE(pm_sr_fops, omap_sr_autocomp_show, > +DEFINE_DEBUGFS_ATTRIBUTE(pm_sr_fops, omap_sr_autocomp_show, > omap_sr_autocomp_store, "%llu\n"); > > static int omap_sr_probe(struct platform_device *pdev) > -- > 1.8.3.1 > LGTM. Reviewed-by: Nishanth Menon <nm@ti.com> Though $subject might be soc: ti: smartreflex after the relocation to maintain consistency.. Upto santosh if he might want to locally change on applying the patch.. -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
diff --git a/drivers/soc/ti/smartreflex.c b/drivers/soc/ti/smartreflex.c index 5376f3d..b3c7460 100644 --- a/drivers/soc/ti/smartreflex.c +++ b/drivers/soc/ti/smartreflex.c @@ -817,7 +817,7 @@ static int omap_sr_autocomp_store(void *data, u64 val) return 0; } -DEFINE_SIMPLE_ATTRIBUTE(pm_sr_fops, omap_sr_autocomp_show, +DEFINE_DEBUGFS_ATTRIBUTE(pm_sr_fops, omap_sr_autocomp_show, omap_sr_autocomp_store, "%llu\n"); static int omap_sr_probe(struct platform_device *pdev)
Fix the following coccicheck warning: ./drivers/soc/ti/smartreflex.c:820:0-23: WARNING: pm_sr_fops should be defined with DEFINE_DEBUGFS_ATTRIBUTE Reported-by: Abaci Robot <abaci@linux.alibaba.com> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> --- drivers/soc/ti/smartreflex.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)