| Message ID | 1413233408-31923-1-git-send-email-balbi@ti.com |
|---|---|
| State | Accepted |
| Commit | 9067bbe5989c39bd4d482edfd4d38ad99d5b081f |
| Headers | show |
Hi Linus, On Mon, Oct 13, 2014 at 03:50:08PM -0500, Felipe Balbi wrote: > pinctrl-baytrail driver provides a proper ->remove() > method on its platform_driver definition, however there's > no way, currently, to unload the driver due to missing > module_exit(). This patch adds module_exit(). > > Signed-off-by: Felipe Balbi <balbi@ti.com> This is a quite trivial patch, so not sure you need an Ack from somebody that has the actual hw. In case you do: Acked-by: David Cohen <david.a.cohen@linux.intel.com> > --- > drivers/pinctrl/pinctrl-baytrail.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/drivers/pinctrl/pinctrl-baytrail.c b/drivers/pinctrl/pinctrl-baytrail.c > index e12e5b0..3ece001 100644 > --- a/drivers/pinctrl/pinctrl-baytrail.c > +++ b/drivers/pinctrl/pinctrl-baytrail.c > @@ -612,5 +612,10 @@ static int __init byt_gpio_init(void) > { > return platform_driver_register(&byt_gpio_driver); > } > - > subsys_initcall(byt_gpio_init); > + > +static void __exit byt_gpio_exit(void) > +{ > + platform_driver_unregister(&byt_gpio_driver); > +} > +module_exit(byt_gpio_exit); > -- > 2.1.0.GIT > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
diff --git a/drivers/pinctrl/pinctrl-baytrail.c b/drivers/pinctrl/pinctrl-baytrail.c index e12e5b0..3ece001 100644 --- a/drivers/pinctrl/pinctrl-baytrail.c +++ b/drivers/pinctrl/pinctrl-baytrail.c @@ -612,5 +612,10 @@ static int __init byt_gpio_init(void) { return platform_driver_register(&byt_gpio_driver); } - subsys_initcall(byt_gpio_init); + +static void __exit byt_gpio_exit(void) +{ + platform_driver_unregister(&byt_gpio_driver); +} +module_exit(byt_gpio_exit);
pinctrl-baytrail driver provides a proper ->remove() method on its platform_driver definition, however there's no way, currently, to unload the driver due to missing module_exit(). This patch adds module_exit(). Signed-off-by: Felipe Balbi <balbi@ti.com> --- drivers/pinctrl/pinctrl-baytrail.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)