| Message ID | 1412942554-752-2-git-send-email-ian.campbell@citrix.com |
|---|---|
| State | New |
| Headers | show |
Ian Campbell writes ("[PATCH RFC OSSTEST 02/19] Osstest/PDU: Add eth008.pm method to control the ARM rack PDU"):
> This controls the eth008 relay board: http://www.robot-electronics.co.uk/htm/eth008tech.htm
>
> Due to the use of the CGI interface this requires firmware version 4+.
In the future we are likely to want to have more community members
working with osstest and that probably means we want to have a less
juicy `inside' to our network.
That probably means nontrivial passwords, but it also probably means
we'll want to stop passing passwords on command lines.
> + my $url = "http://$mo->{PDU}/io.cgi?$op$mo->{Port}=0";
> + my $cmd = "curl --silent --user $mo->{User}:$mo->{Pass} $url";
Is there a way to do this where the password goes in a file or via an
fd ?
I'm tempted to suggest that you should use the non-CGI interface and
get the firewall fixed...
Ian.
On Fri, 2014-10-10 at 14:56 +0100, Ian Jackson wrote: > Ian Campbell writes ("[PATCH RFC OSSTEST 02/19] Osstest/PDU: Add eth008.pm method to control the ARM rack PDU"): > > This controls the eth008 relay board: http://www.robot-electronics.co.uk/htm/eth008tech.htm > > > > Due to the use of the CGI interface this requires firmware version 4+. > > In the future we are likely to want to have more community members > working with osstest and that probably means we want to have a less > juicy `inside' to our network. > > That probably means nontrivial passwords, but it also probably means > we'll want to stop passing passwords on command lines. > > > + my $url = "http://$mo->{PDU}/io.cgi?$op$mo->{Port}=0"; > > + my $cmd = "curl --silent --user $mo->{User}:$mo->{Pass} $url"; > > Is there a way to do this where the password goes in a file or via an > fd ? There's --netrc which looks in ~/.netrc (or use --netrc-file). > I'm tempted to suggest that you should use the non-CGI interface and > get the firewall fixed... Probably easiest to do it as part of the move, when we (I pressume) gain control over the f/w, if any, between control host and test machines? I could code it as an option for now if you like. Ian.
diff --git a/Osstest/PDU/eth008.pm b/Osstest/PDU/eth008.pm new file mode 100644 index 0000000..da6af78 --- /dev/null +++ b/Osstest/PDU/eth008.pm @@ -0,0 +1,68 @@ +# This is part of "osstest", an automated testing framework for Xen. +# Copyright (C) 2014 Citrix Inc. +# +# This program is free software: you can redistribute it and/or modify +# it under the terms of the GNU Affero General Public License as published by +# the Free Software Foundation, either version 3 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU Affero General Public License for more details. +# +# You should have received a copy of the GNU Affero General Public License +# along with this program. If not, see <http://www.gnu.org/licenses/>. + +package Osstest::PDU::eth008; + +use strict; +use warnings; + +use Osstest; +use Osstest::TestSupport; +use IO::File; + +BEGIN { + use Exporter (); + our ($VERSION, @ISA, @EXPORT, @EXPORT_OK, %EXPORT_TAGS); + $VERSION = 1.00; + @ISA = qw(Exporter); + @EXPORT = qw(); + %EXPORT_TAGS = ( ); + + @EXPORT_OK = qw(); +} + +sub new { + my ($class, $ho, $methname, $pdu, $user, $pass, $port, @opts) = @_; + return bless { Host => $ho, + PDU => $pdu, + User => $user, + Pass => $pass, + Port => $port, + Opts => \@opts }, $class; +} + +sub pdu_power_state { + my ($mo, $on) = @_; + my $op= $on ? "DOA" : "DOI"; # Digital Output (In)Active + + # Use the CGI interface since it is less prone to being firewalled + # off, unlike the standard interface on port 17494. This is only + # available from firmware v4 onwards. + + my $url = "http://$mo->{PDU}/io.cgi?$op$mo->{Port}=0"; + my $cmd = "curl --silent --user $mo->{User}:$mo->{Pass} $url"; + + logm("$cmd"); + open CURL, "$cmd |" or die "fork curl: $!"; + + my $result = <CURL>; + close CURL or die "result curl: $!"; + + logm("$result"); + die "curl failed" unless $result =~ /^Success! \d+/; +} + +1;
This controls the eth008 relay board: http://www.robot-electronics.co.uk/htm/eth008tech.htm Due to the use of the CGI interface this requires firmware version 4+. Signed-off-by: Ian Campbell <ian.campbell@citrix.com> --- Osstest/PDU/eth008.pm | 68 +++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 68 insertions(+) create mode 100644 Osstest/PDU/eth008.pm