diff mbox series

[3/3] mfd: lp87565: move LP87565_regulator_id to .c file

Message ID 20210219223910.1831-3-luca@lucaceresoli.net
State Accepted
Commit 5258f7eed42f4565d065726fd82d3430dd618a68
Headers show
Series [1/3] mfd: lp87565: fix typo in define names | expand

Commit Message

Luca Ceresoli Feb. 19, 2021, 10:39 p.m. UTC
This enum is used only internally to the regulator driver for buck indexes.

Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
---
 drivers/regulator/lp87565-regulator.c | 11 +++++++++++
 include/linux/mfd/lp87565.h           | 11 -----------
 2 files changed, 11 insertions(+), 11 deletions(-)

Comments

Lee Jones March 8, 2021, 2:07 p.m. UTC | #1
On Fri, 19 Feb 2021, Luca Ceresoli wrote:

> This enum is used only internally to the regulator driver for buck indexes.

> 

> Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>

> ---

>  drivers/regulator/lp87565-regulator.c | 11 +++++++++++

>  include/linux/mfd/lp87565.h           | 11 -----------

>  2 files changed, 11 insertions(+), 11 deletions(-)


For my own reference (apply this as-is to your sign-off block):

  Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org>

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
diff mbox series

Patch

diff --git a/drivers/regulator/lp87565-regulator.c b/drivers/regulator/lp87565-regulator.c
index eeab9d3c824b..d059ae85047a 100644
--- a/drivers/regulator/lp87565-regulator.c
+++ b/drivers/regulator/lp87565-regulator.c
@@ -11,6 +11,17 @@ 
 
 #include <linux/mfd/lp87565.h>
 
+enum LP87565_regulator_id {
+	/* BUCK's */
+	LP87565_BUCK_0,
+	LP87565_BUCK_1,
+	LP87565_BUCK_2,
+	LP87565_BUCK_3,
+	LP87565_BUCK_10,
+	LP87565_BUCK_23,
+	LP87565_BUCK_3210,
+};
+
 #define LP87565_REGULATOR(_name, _id, _of, _ops, _n, _vr, _vm,		\
 			  _er, _em, _ev, _delay, _lr, _cr)		\
 	[_id] = {							\
diff --git a/include/linux/mfd/lp87565.h b/include/linux/mfd/lp87565.h
index a8799ae50dcf..94cb581af34b 100644
--- a/include/linux/mfd/lp87565.h
+++ b/include/linux/mfd/lp87565.h
@@ -237,17 +237,6 @@  enum lp87565_device_type {
 #define LP87565_GPIO2_OUT			BIT(1)
 #define LP87565_GPIO1_OUT			BIT(0)
 
-enum LP87565_regulator_id {
-	/* BUCK's */
-	LP87565_BUCK_0,
-	LP87565_BUCK_1,
-	LP87565_BUCK_2,
-	LP87565_BUCK_3,
-	LP87565_BUCK_10,
-	LP87565_BUCK_23,
-	LP87565_BUCK_3210,
-};
-
 /**
  * struct LP87565 - state holder for the LP87565 driver
  * @dev: struct device pointer for MFD device