diff mbox series

drivers: firmware: fix kconfig dependency on CRYPTO

Message ID 3079145.qOpluECk2m@ubuntu-mate-laptop
State Superseded
Headers show
Series drivers: firmware: fix kconfig dependency on CRYPTO | expand

Commit Message

Julian Braha Feb. 19, 2021, 11:46 p.m. UTC
commit 72304490d9df7d6af2e6851cc5762908abd52889
Author: Julian Braha <julianbraha@gmail.com>
Date:   Fri Feb 19 18:36:22 2021 -0500

    drivers: firmware: fix kconfig dependency on CRYPTO
    
    When EFI_EMBEDDED_FIRMWARE is enabled and CRYPTO is disabled,
    Kbuild gives the following warning:
    
    WARNING: unmet direct dependencies detected for CRYPTO_LIB_SHA256
      Depends on [n]: CRYPTO [=n]
      Selected by [y]:
      - EFI_EMBEDDED_FIRMWARE [=y] && EFI [=y]
    
    This is because EFI_EMBEDDED_FIRMWARE selects CRYPTO_LIB_SHA256,
    without depending on or selecting CRYPTO, despite that config option
    being subordinate to CRYPTO.
    
    Signed-off-by: Julian Braha <julianbraha@gmail.com>
diff mbox series

Patch

diff --git a/drivers/firmware/efi/Kconfig b/drivers/firmware/efi/Kconfig
index 2c3dac5ecb36..f914da9845ac 100644
--- a/drivers/firmware/efi/Kconfig
+++ b/drivers/firmware/efi/Kconfig
@@ -248,6 +248,7 @@  endmenu
 config EFI_EMBEDDED_FIRMWARE
        bool
        depends on EFI
+       select CRYPTO
        select CRYPTO_LIB_SHA256
 
 config UEFI_CPER