| Message ID | 20210212111046.170342-1-ydewid@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v3] Goodix Fingerprint device is not a modem | expand |
Am Freitag, den 12.02.2021, 12:10 +0100 schrieb Yorick de Wid: > The CDC ACM driver is false matching the Goodix Fingerprint device against > the USB_CDC_ACM_PROTO_AT_V25TER. Hi, what else is it? Which driver should be used or is it to be handled in user space? That needs to go into the change log. Otherwise this patch just looks like it drops every access to the device. Regards Oliver
diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c index 78190574581..2f4e5174e78 100644 --- a/drivers/usb/class/cdc-acm.c +++ b/drivers/usb/class/cdc-acm.c @@ -1929,6 +1929,11 @@ static const struct usb_device_id acm_ids[] = { .driver_info = SEND_ZERO_PACKET, }, + /* Exclude Goodix Fingerprint Reader */ + { USB_DEVICE(0x27c6, 0x5395), + .driver_info = IGNORE_DEVICE, + }, + /* control interfaces without any protocol set */ { USB_INTERFACE_INFO(USB_CLASS_COMM, USB_CDC_SUBCLASS_ACM, USB_CDC_PROTO_NONE) },
The CDC ACM driver is false matching the Goodix Fingerprint device against the USB_CDC_ACM_PROTO_AT_V25TER. Keep the entries sorted on in VID/PID. Signed-off-by: Yorick de Wid <ydewid@gmail.com> --- drivers/usb/class/cdc-acm.c | 5 +++++ 1 file changed, 5 insertions(+)