diff mbox series

[v4,1/2] pinctrl: use to octal permissions for debugfs files

Message ID 20210210222851.232374-2-drew@beagleboard.org
State Superseded
Headers show
Series pinctrl: pinmux: Add pinmux-select debugfs file | expand

Commit Message

Drew Fustini Feb. 10, 2021, 10:28 p.m. UTC
Switch over pinctrl debugfs files to use octal permissions as they are
preferred over symbolic permissions. Refer to commit f90774e1fd27
("checkpatch: look for symbolic permissions and suggest octal instead").

Note: S_IFREG flag is added to the mode by __debugfs_create_file()
in fs/debugfs/inode.c

Suggested-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Drew Fustini <drew@beagleboard.org>
---
 drivers/pinctrl/core.c    | 6 +++---
 drivers/pinctrl/pinconf.c | 4 ++--
 drivers/pinctrl/pinmux.c  | 4 ++--
 3 files changed, 7 insertions(+), 7 deletions(-)

Comments

Joe Perches Feb. 11, 2021, 7:36 a.m. UTC | #1
On Wed, 2021-02-10 at 14:28 -0800, Drew Fustini wrote:
> Switch over pinctrl debugfs files to use octal permissions as they are

> preferred over symbolic permissions. Refer to commit f90774e1fd27

> ("checkpatch: look for symbolic permissions and suggest octal instead").

> 

> Note: S_IFREG flag is added to the mode by __debugfs_create_file()

> in fs/debugfs/inode.c

> 

> Suggested-by: Andy Shevchenko <andy.shevchenko@gmail.com>

> Signed-off-by: Drew Fustini <drew@beagleboard.org>

> ---

>  drivers/pinctrl/core.c    | 6 +++---

>  drivers/pinctrl/pinconf.c | 4 ++--

>  drivers/pinctrl/pinmux.c  | 4 ++--

>  3 files changed, 7 insertions(+), 7 deletions(-)

> 

> diff --git a/drivers/pinctrl/core.c b/drivers/pinctrl/core.c

> index 3663d87f51a0..02f8710afb9c 100644

> --- a/drivers/pinctrl/core.c

> +++ b/drivers/pinctrl/core.c

> @@ -1914,11 +1914,11 @@ static void pinctrl_init_debugfs(void)

>  		return;

>  	}

>  

> 

> -	debugfs_create_file("pinctrl-devices", S_IFREG | S_IRUGO,

> +	debugfs_create_file("pinctrl-devices", 0444,

>  			    debugfs_root, NULL, &pinctrl_devices_fops);

> -	debugfs_create_file("pinctrl-maps", S_IFREG | S_IRUGO,

> +	debugfs_create_file("pinctrl-maps", 0444,

>  			    debugfs_root, NULL, &pinctrl_maps_fops);

> -	debugfs_create_file("pinctrl-handles", S_IFREG | S_IRUGO,

> +	debugfs_create_file("pinctrl-handles", 0444,

>  			    debugfs_root, NULL, &pinctrl_fops);

>  }


Why aren't you also converting this block in the same file?

@@ -1890,11 +1890,11 @@ static void pinctrl_init_device_debugfs(struct pinctrl_dev *pctldev)
                        dev_name(pctldev->dev));
                return;
        }
-       debugfs_create_file("pins", S_IFREG | S_IRUGO,
+       debugfs_create_file("pins", S_IFREG | 0444,
                            device_root, pctldev, &pinctrl_pins_fops);
-       debugfs_create_file("pingroups", S_IFREG | S_IRUGO,
+       debugfs_create_file("pingroups", S_IFREG | 0444,
                            device_root, pctldev, &pinctrl_groups_fops);
-       debugfs_create_file("gpio-ranges", S_IFREG | S_IRUGO,
+       debugfs_create_file("gpio-ranges", S_IFREG | 0444,
                            device_root, pctldev, &pinctrl_gpioranges_fops);
        if (pctldev->desc->pmxops)
                pinmux_init_device_debugfs(device_root, pctldev);
Drew Fustini Feb. 11, 2021, 7:52 a.m. UTC | #2
On Wed, Feb 10, 2021 at 11:36:39PM -0800, Joe Perches wrote:
> On Wed, 2021-02-10 at 14:28 -0800, Drew Fustini wrote:

> > Switch over pinctrl debugfs files to use octal permissions as they are

> > preferred over symbolic permissions. Refer to commit f90774e1fd27

> > ("checkpatch: look for symbolic permissions and suggest octal instead").

> > 

> > Note: S_IFREG flag is added to the mode by __debugfs_create_file()

> > in fs/debugfs/inode.c

> > 

> > Suggested-by: Andy Shevchenko <andy.shevchenko@gmail.com>

> > Signed-off-by: Drew Fustini <drew@beagleboard.org>

> > ---

> >  drivers/pinctrl/core.c    | 6 +++---

> >  drivers/pinctrl/pinconf.c | 4 ++--

> >  drivers/pinctrl/pinmux.c  | 4 ++--

> >  3 files changed, 7 insertions(+), 7 deletions(-)

> > 

> > diff --git a/drivers/pinctrl/core.c b/drivers/pinctrl/core.c

> > index 3663d87f51a0..02f8710afb9c 100644

> > --- a/drivers/pinctrl/core.c

> > +++ b/drivers/pinctrl/core.c

> > @@ -1914,11 +1914,11 @@ static void pinctrl_init_debugfs(void)

> >  		return;

> >  	}

> >  

> > 

> > -	debugfs_create_file("pinctrl-devices", S_IFREG | S_IRUGO,

> > +	debugfs_create_file("pinctrl-devices", 0444,

> >  			    debugfs_root, NULL, &pinctrl_devices_fops);

> > -	debugfs_create_file("pinctrl-maps", S_IFREG | S_IRUGO,

> > +	debugfs_create_file("pinctrl-maps", 0444,

> >  			    debugfs_root, NULL, &pinctrl_maps_fops);

> > -	debugfs_create_file("pinctrl-handles", S_IFREG | S_IRUGO,

> > +	debugfs_create_file("pinctrl-handles", 0444,

> >  			    debugfs_root, NULL, &pinctrl_fops);

> >  }

> 

> Why aren't you also converting this block in the same file?

> 

> @@ -1890,11 +1890,11 @@ static void pinctrl_init_device_debugfs(struct pinctrl_dev *pctldev)

>                         dev_name(pctldev->dev));

>                 return;

>         }

> -       debugfs_create_file("pins", S_IFREG | S_IRUGO,

> +       debugfs_create_file("pins", S_IFREG | 0444,

>                             device_root, pctldev, &pinctrl_pins_fops);

> -       debugfs_create_file("pingroups", S_IFREG | S_IRUGO,

> +       debugfs_create_file("pingroups", S_IFREG | 0444,

>                             device_root, pctldev, &pinctrl_groups_fops);

> -       debugfs_create_file("gpio-ranges", S_IFREG | S_IRUGO,

> +       debugfs_create_file("gpio-ranges", S_IFREG | 0444,

>                             device_root, pctldev, &pinctrl_gpioranges_fops);

>         if (pctldev->desc->pmxops)

>                 pinmux_init_device_debugfs(device_root, pctldev);

> 

> 

> 


Thank you, that is a very good point.  I should have included those
calls to debugfs_create_file() in the patch as well.  I will fix that
in the next revision.  It looks like I also need to change how sscanf()
is being handle per the other thread of discussion.

Thanks,
Drew
diff mbox series

Patch

diff --git a/drivers/pinctrl/core.c b/drivers/pinctrl/core.c
index 3663d87f51a0..02f8710afb9c 100644
--- a/drivers/pinctrl/core.c
+++ b/drivers/pinctrl/core.c
@@ -1914,11 +1914,11 @@  static void pinctrl_init_debugfs(void)
 		return;
 	}
 
-	debugfs_create_file("pinctrl-devices", S_IFREG | S_IRUGO,
+	debugfs_create_file("pinctrl-devices", 0444,
 			    debugfs_root, NULL, &pinctrl_devices_fops);
-	debugfs_create_file("pinctrl-maps", S_IFREG | S_IRUGO,
+	debugfs_create_file("pinctrl-maps", 0444,
 			    debugfs_root, NULL, &pinctrl_maps_fops);
-	debugfs_create_file("pinctrl-handles", S_IFREG | S_IRUGO,
+	debugfs_create_file("pinctrl-handles", 0444,
 			    debugfs_root, NULL, &pinctrl_fops);
 }
 
diff --git a/drivers/pinctrl/pinconf.c b/drivers/pinctrl/pinconf.c
index 02c075cc010b..d9d54065472e 100644
--- a/drivers/pinctrl/pinconf.c
+++ b/drivers/pinctrl/pinconf.c
@@ -370,9 +370,9 @@  DEFINE_SHOW_ATTRIBUTE(pinconf_groups);
 void pinconf_init_device_debugfs(struct dentry *devroot,
 			 struct pinctrl_dev *pctldev)
 {
-	debugfs_create_file("pinconf-pins", S_IFREG | S_IRUGO,
+	debugfs_create_file("pinconf-pins", 0444,
 			    devroot, pctldev, &pinconf_pins_fops);
-	debugfs_create_file("pinconf-groups", S_IFREG | S_IRUGO,
+	debugfs_create_file("pinconf-groups", 0444,
 			    devroot, pctldev, &pinconf_groups_fops);
 }
 
diff --git a/drivers/pinctrl/pinmux.c b/drivers/pinctrl/pinmux.c
index bab888fe3f8e..c651b2db0925 100644
--- a/drivers/pinctrl/pinmux.c
+++ b/drivers/pinctrl/pinmux.c
@@ -676,9 +676,9 @@  DEFINE_SHOW_ATTRIBUTE(pinmux_pins);
 void pinmux_init_device_debugfs(struct dentry *devroot,
 			 struct pinctrl_dev *pctldev)
 {
-	debugfs_create_file("pinmux-functions", S_IFREG | S_IRUGO,
+	debugfs_create_file("pinmux-functions", 0444,
 			    devroot, pctldev, &pinmux_functions_fops);
-	debugfs_create_file("pinmux-pins", S_IFREG | S_IRUGO,
+	debugfs_create_file("pinmux-pins", 0444,
 			    devroot, pctldev, &pinmux_pins_fops);
 }