diff mbox series

[for-next,07/32] scsi: a2091: Replace spin_lock_irqsave with spin_lock in hard IRQ

Message ID 1612697823-8073-8-git-send-email-tanxiaofei@huawei.com
State New
Headers show
Series spin lock usage optimization for SCSI drivers | expand

Commit Message

Xiaofei Tan Feb. 7, 2021, 11:36 a.m. UTC 
It is redundant to do irqsave and irqrestore in hardIRQ context, where
it has been in a irq-disabled context.

Signed-off-by: Xiaofei Tan <tanxiaofei@huawei.com>
---
 drivers/scsi/a2091.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
diff mbox series

Patch

diff --git a/drivers/scsi/a2091.c b/drivers/scsi/a2091.c
index 5853db3..5b23602 100644
--- a/drivers/scsi/a2091.c
+++ b/drivers/scsi/a2091.c
@@ -27,14 +27,13 @@  static irqreturn_t a2091_intr(int irq, void *data)
 	struct Scsi_Host *instance = data;
 	struct a2091_hostdata *hdata = shost_priv(instance);
 	unsigned int status = hdata->regs->ISTR;
-	unsigned long flags;
 
 	if (!(status & (ISTR_INT_F | ISTR_INT_P)) || !(status & ISTR_INTS))
 		return IRQ_NONE;
 
-	spin_lock_irqsave(instance->host_lock, flags);
+	spin_lock(instance->host_lock);
 	wd33c93_intr(instance);
-	spin_unlock_irqrestore(instance->host_lock, flags);
+	spin_unlock(instance->host_lock);
 	return IRQ_HANDLED;
 }