diff mbox series

[v5,01/19] crypto: amcc: convert tasklets to use new tasklet_setup() API

Message ID 20210208094238.571015-2-allen.lkml@gmail.com
State New
Headers show
Series [v5,01/19] crypto: amcc: convert tasklets to use new tasklet_setup() API | expand

Commit Message

Allen Pais Feb. 8, 2021, 9:42 a.m. UTC 
From: Allen Pais <apais@linux.microsoft.com>

In preparation for unconditionally passing the
struct tasklet_struct pointer to all tasklet
callbacks, switch to using the new tasklet_setup()
and from_tasklet() to pass the tasklet pointer explicitly.

Signed-off-by: Romain Perier <romain.perier@gmail.com>
Signed-off-by: Allen Pais <apais@linux.microsoft.com>
---
 drivers/crypto/amcc/crypto4xx_core.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

Comments

Herbert Xu March 4, 2021, 6:26 a.m. UTC | #1 
On Mon, Feb 08, 2021 at 03:12:20PM +0530, Allen Pais wrote:
> From: Allen Pais <apais@linux.microsoft.com>

> 

> In preparation for unconditionally passing the

> struct tasklet_struct pointer to all tasklet

> callbacks, switch to using the new tasklet_setup()

> and from_tasklet() to pass the tasklet pointer explicitly.

> 

> Signed-off-by: Romain Perier <romain.perier@gmail.com>

> Signed-off-by: Allen Pais <apais@linux.microsoft.com>

> ---

>  drivers/crypto/amcc/crypto4xx_core.c | 10 +++++-----

>  1 file changed, 5 insertions(+), 5 deletions(-)


This introduces a compiler warning with C=1 W=1.

Cheers,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Allen Pais March 9, 2021, 9:29 a.m. UTC | #2 
>>

>> In preparation for unconditionally passing the

>> struct tasklet_struct pointer to all tasklet

>> callbacks, switch to using the new tasklet_setup()

>> and from_tasklet() to pass the tasklet pointer explicitly.

>>

>> Signed-off-by: Romain Perier <romain.perier@gmail.com>

>> Signed-off-by: Allen Pais <apais@linux.microsoft.com>

>> ---

>>   drivers/crypto/amcc/crypto4xx_core.c | 10 +++++-----

>>   1 file changed, 5 insertions(+), 5 deletions(-)

> 

> This introduces a compiler warning with C=1 W=1.


Okay. I will check and send out a fix.

Thanks.
diff mbox series

Patch

diff --git a/drivers/crypto/amcc/crypto4xx_core.c b/drivers/crypto/amcc/crypto4xx_core.c
index 8d1b918a0533..721ccf850f0b 100644
--- a/drivers/crypto/amcc/crypto4xx_core.c
+++ b/drivers/crypto/amcc/crypto4xx_core.c
@@ -1072,10 +1072,11 @@  static void crypto4xx_unregister_alg(struct crypto4xx_device *sec_dev)
 	}
 }
 
-static void crypto4xx_bh_tasklet_cb(unsigned long data)
+static void crypto4xx_bh_tasklet_cb(struct tasklet_struct *t)
 {
-	struct device *dev = (struct device *)data;
-	struct crypto4xx_core_device *core_dev = dev_get_drvdata(dev);
+	struct crypto4xx_core_device *core_dev = from_tasklet(core_dev, t,
+							      tasklet);
+	struct device *dev = core_dev->device;
 	struct pd_uinfo *pd_uinfo;
 	struct ce_pd *pd;
 	u32 tail = core_dev->dev->pdr_tail;
@@ -1452,8 +1453,7 @@  static int crypto4xx_probe(struct platform_device *ofdev)
 		goto err_build_sdr;
 
 	/* Init tasklet for bottom half processing */
-	tasklet_init(&core_dev->tasklet, crypto4xx_bh_tasklet_cb,
-		     (unsigned long) dev);
+	tasklet_setup(&core_dev->tasklet, crypto4xx_bh_tasklet_cb);
 
 	core_dev->dev->ce_base = of_iomap(ofdev->dev.of_node, 0);
 	if (!core_dev->dev->ce_base) {