diff mbox series

[PULL,08/16] configure: make version_ge more tolerant of shady version input

Message ID 20210208123821.19818-9-alex.bennee@linaro.org
State New
Headers show
Series testing, gdbstub and doc tweaks | expand

Commit Message

Alex Bennée Feb. 8, 2021, 12:38 p.m. UTC 
When checking GDB versions we have to tolerate all sorts of random
distro extensions to the version string. While we already attempt to
do some of that before we call version_ge is makes sense to try and
regularise the first input by stripping extraneous -'s. While we at it
convert the old-style shell quoting into a cleaner form t shut up my
editors linter lest it confuse me by underlining the whole line.

Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

Tested-by: Thomas Huth <thuth@redhat.com>

Reviewed-by: Eric Blake <eblake@redhat.com>

Message-Id: <20210202134001.25738-8-alex.bennee@linaro.org>

-- 
2.20.1
diff mbox series

Patch

diff --git a/configure b/configure
index a34f91171d..36036aa2f2 100755
--- a/configure
+++ b/configure
@@ -198,8 +198,8 @@  has() {
 }
 
 version_ge () {
-    local_ver1=`echo $1 | tr . ' '`
-    local_ver2=`echo $2 | tr . ' '`
+    local_ver1=$(expr "$1" : '\([0-9.]*\)' | tr . ' ')
+    local_ver2=$(echo "$2" | tr . ' ')
     while true; do
         set x $local_ver1
         local_first=${2-0}