diff mbox

gpio: dwapb: fix pointer to integer cast

Message ID 1411558300-20555-1-git-send-email-linus.walleij@linaro.org
State Accepted
Commit 58a3b92d33d289e2f3390b40a2c5cfd7f32cfe7a
Headers show

Commit Message

Linus Walleij Sept. 24, 2014, 11:31 a.m. UTC 
The statements BUG_ON(ctx == 0) was implicitly casting a pointer
to an integer for comparison. Do this with a bool test instead
to get away from sparse warnings.

Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
 drivers/gpio/gpio-dwapb.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff mbox

Patch

diff --git a/drivers/gpio/gpio-dwapb.c b/drivers/gpio/gpio-dwapb.c
index 7feaf9d3f3ca..b43cd84b61f1 100644
--- a/drivers/gpio/gpio-dwapb.c
+++ b/drivers/gpio/gpio-dwapb.c
@@ -626,7 +626,7 @@  static int dwapb_gpio_suspend(struct device *dev)
 		unsigned int idx = gpio->ports[i].idx;
 		struct dwapb_context *ctx = gpio->ports[i].ctx;
 
-		BUG_ON(ctx == 0);
+		BUG_ON(!ctx);
 
 		offset = GPIO_SWPORTA_DDR + idx * GPIO_SWPORT_DDR_SIZE;
 		ctx->dir = dwapb_read(gpio, offset);
@@ -668,7 +668,7 @@  static int dwapb_gpio_resume(struct device *dev)
 		unsigned int idx = gpio->ports[i].idx;
 		struct dwapb_context *ctx = gpio->ports[i].ctx;
 
-		BUG_ON(ctx == 0);
+		BUG_ON(!ctx);
 
 		offset = GPIO_SWPORTA_DR + idx * GPIO_SWPORT_DR_SIZE;
 		dwapb_write(gpio, offset, ctx->data);