diff mbox series

Revert "dts: phy: add GPIO number and active state used for phy reset"

Message ID 20210205034112.2147142-1-palmer@dabbelt.com
State New
Headers show
Series Revert "dts: phy: add GPIO number and active state used for phy reset" | expand

Commit Message

Palmer Dabbelt Feb. 5, 2021, 3:41 a.m. UTC 
From: Palmer Dabbelt <palmerdabbelt@google.com>

VSC8541 phys need a special reset sequence, which the driver doesn't
currentlny support.  As a result enabling the reset via GPIO essentially
guarnteees that the device won't work correctly.

This reverts commit a0fa9d727043da2238432471e85de0bdb8a8df65.

Fixes: a0fa9d727043 ("dts: phy: add GPIO number and active state used for phy reset")
Cc: stable@vger.kernel.org
Signed-off-by: Palmer Dabbelt <palmerdabbelt@google.com>
---
 arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts | 1 -
 1 file changed, 1 deletion(-)

Comments

Andreas Schwab Feb. 10, 2021, 12:47 p.m. UTC | #1 
On Feb 04 2021, Palmer Dabbelt wrote:

> From: Palmer Dabbelt <palmerdabbelt@google.com>
>
> VSC8541 phys need a special reset sequence, which the driver doesn't
> currentlny support.  As a result enabling the reset via GPIO essentially
> guarnteees that the device won't work correctly.
>
> This reverts commit a0fa9d727043da2238432471e85de0bdb8a8df65.
>
> Fixes: a0fa9d727043 ("dts: phy: add GPIO number and active state used for phy reset")
> Cc: stable@vger.kernel.org
> Signed-off-by: Palmer Dabbelt <palmerdabbelt@google.com>

This fixes ethernet on the HiFive Unleashed with 5.10.12.

Andreas.
Palmer Dabbelt Feb. 13, 2021, 12:43 a.m. UTC | #2 
On Wed, 10 Feb 2021 04:47:34 PST (-0800), schwab@linux-m68k.org wrote:
> On Feb 04 2021, Palmer Dabbelt wrote:

>

>> From: Palmer Dabbelt <palmerdabbelt@google.com>

>>

>> VSC8541 phys need a special reset sequence, which the driver doesn't

>> currentlny support.  As a result enabling the reset via GPIO essentially

>> guarnteees that the device won't work correctly.

>>

>> This reverts commit a0fa9d727043da2238432471e85de0bdb8a8df65.

>>

>> Fixes: a0fa9d727043 ("dts: phy: add GPIO number and active state used for phy reset")

>> Cc: stable@vger.kernel.org

>> Signed-off-by: Palmer Dabbelt <palmerdabbelt@google.com>

>

> This fixes ethernet on the HiFive Unleashed with 5.10.12.


Thanks for testing.  Looks like I forgot to reply, but it's in Linus' tree and 
should end up in stable.
diff mbox series

Patch

diff --git a/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts
index 24d75a146e02..60846e88ae4b 100644
--- a/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts
+++ b/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts
@@ -90,7 +90,6 @@  &eth0 {
 	phy0: ethernet-phy@0 {
 		compatible = "ethernet-phy-id0007.0771";
 		reg = <0>;
-		reset-gpios = <&gpio 12 GPIO_ACTIVE_LOW>;
 	};
 };