| Message ID | 20210204111000.2800436-7-lee.jones@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Rid W=1 warnings in Crypto | expand |
On Thu, 2021-02-04 at 11:09 +0000, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/crypto/keembay/ocs-hcu.c:107: warning: expecting prototype for struct ocs_hcu_dma_list. Prototype was for struct ocs_hcu_dma_entry instead > drivers/crypto/keembay/ocs-hcu.c:127: warning: expecting prototype for struct ocs_dma_list. Prototype was for struct ocs_hcu_dma_list instead > drivers/crypto/keembay/ocs-hcu.c:610: warning: expecting prototype for ocs_hcu_digest(). Prototype was for ocs_hcu_hash_update() instead > drivers/crypto/keembay/ocs-hcu.c:648: warning: expecting prototype for ocs_hcu_hash_final(). Prototype was for ocs_hcu_hash_finup() instead > > Cc: Daniele Alessandrelli <daniele.alessandrelli@intel.com> > Cc: Declan Murphy <declan.murphy@intel.com> > Cc: Herbert Xu <herbert@gondor.apana.org.au> > Cc: "David S. Miller" <davem@davemloft.net> > Cc: linux-crypto@vger.kernel.org > Signed-off-by: Lee Jones <lee.jones@linaro.org> > --- Acked-by: Daniele Alessandrelli <daniele.alessandrelli@intel.com> Thanks for fixing these. For some reason, if the issues are there, I don't get those warnings when compiling with W=1; the command I run is: make CROSS_COMPILE=<arm-compiler> ARCH=arm64 -j5 W=4 M=drivers/crypto/keembay Which command are you running exactly? I'll use it for my next submissions.
On Thu, 04 Feb 2021, Alessandrelli, Daniele wrote: > On Thu, 2021-02-04 at 11:09 +0000, Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > > > drivers/crypto/keembay/ocs-hcu.c:107: warning: expecting prototype for struct ocs_hcu_dma_list. Prototype was for struct ocs_hcu_dma_entry instead > > drivers/crypto/keembay/ocs-hcu.c:127: warning: expecting prototype for struct ocs_dma_list. Prototype was for struct ocs_hcu_dma_list instead > > drivers/crypto/keembay/ocs-hcu.c:610: warning: expecting prototype for ocs_hcu_digest(). Prototype was for ocs_hcu_hash_update() instead > > drivers/crypto/keembay/ocs-hcu.c:648: warning: expecting prototype for ocs_hcu_hash_final(). Prototype was for ocs_hcu_hash_finup() instead > > > > Cc: Daniele Alessandrelli <daniele.alessandrelli@intel.com> > > Cc: Declan Murphy <declan.murphy@intel.com> > > Cc: Herbert Xu <herbert@gondor.apana.org.au> > > Cc: "David S. Miller" <davem@davemloft.net> > > Cc: linux-crypto@vger.kernel.org > > Signed-off-by: Lee Jones <lee.jones@linaro.org> > > --- > > Acked-by: Daniele Alessandrelli <daniele.alessandrelli@intel.com> > > > Thanks for fixing these. > > For some reason, if the issues are there, I don't get those warnings > when compiling with W=1; the command I run is: > > make CROSS_COMPILE=<arm-compiler> ARCH=arm64 -j5 W=4 M=drivers/crypto/keembay Not sure what would happen with 'W=4'. Probably nothing, as it only goes up to 3 [0]. > Which command are you running exactly? I'll use it for my next > submissions. rm -rf ../builds/build-arm64/drivers/crypto/ make -f Makefile -j24 --quiet ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- KBUILD_OUTPUT=../builds/build-arm64 allmodconfig make -f Makefile -j24 --quiet ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- KBUILD_OUTPUT=../builds/build-arm64 W=1 drivers/crypto/ Hope that helps. [0] scripts/Makefile.extrawarn -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
On Thu, 2021-02-04 at 18:55 +0000, Lee Jones wrote: > On Thu, 04 Feb 2021, Alessandrelli, Daniele wrote: > > > On Thu, 2021-02-04 at 11:09 +0000, Lee Jones wrote: > > > Fixes the following W=1 kernel build warning(s): > > > > > > drivers/crypto/keembay/ocs-hcu.c:107: warning: expecting prototype for struct ocs_hcu_dma_list. Prototype was for struct ocs_hcu_dma_entry instead > > > drivers/crypto/keembay/ocs-hcu.c:127: warning: expecting prototype for struct ocs_dma_list. Prototype was for struct ocs_hcu_dma_list instead > > > drivers/crypto/keembay/ocs-hcu.c:610: warning: expecting prototype for ocs_hcu_digest(). Prototype was for ocs_hcu_hash_update() instead > > > drivers/crypto/keembay/ocs-hcu.c:648: warning: expecting prototype for ocs_hcu_hash_final(). Prototype was for ocs_hcu_hash_finup() instead > > > > > > Cc: Daniele Alessandrelli <daniele.alessandrelli@intel.com> > > > Cc: Declan Murphy <declan.murphy@intel.com> > > > Cc: Herbert Xu <herbert@gondor.apana.org.au> > > > Cc: "David S. Miller" <davem@davemloft.net> > > > Cc: linux-crypto@vger.kernel.org > > > Signed-off-by: Lee Jones <lee.jones@linaro.org> > > > --- > > > > Acked-by: Daniele Alessandrelli <daniele.alessandrelli@intel.com> > > > > > > Thanks for fixing these. > > > > For some reason, if the issues are there, I don't get those warnings > > when compiling with W=1; the command I run is: > > > > make CROSS_COMPILE=<arm-compiler> ARCH=arm64 -j5 W=4 M=drivers/crypto/keembay > > Not sure what would happen with 'W=4'. Sorry that was a typo (I meant to write W=1) :/ > > Probably nothing, as it only goes up to 3 [0]. > > > Which command are you running exactly? I'll use it for my next > > submissions. > > rm -rf ../builds/build-arm64/drivers/crypto/ > make -f Makefile -j24 --quiet ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- KBUILD_OUTPUT=../builds/build-arm64 allmodconfig > make -f Makefile -j24 --quiet ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- KBUILD_OUTPUT=../builds/build-arm64 W=1 drivers/crypto/ > > Hope that helps. Thanks for providing your commands. Unfortunately, even if I run them I don't get the above warnings. I wonder if the issue is in my version of scripts/kernel-doc (which seems to be the script called by the Makefile to to check the kernel- doc). I'll keep investigating this. Thanks again! > > [0] scripts/Makefile.extrawarn >
diff --git a/drivers/crypto/keembay/ocs-hcu.c b/drivers/crypto/keembay/ocs-hcu.c index 81eecacf603ad..d522757855fb0 100644 --- a/drivers/crypto/keembay/ocs-hcu.c +++ b/drivers/crypto/keembay/ocs-hcu.c @@ -93,7 +93,7 @@ #define OCS_HCU_WAIT_BUSY_TIMEOUT_US 1000000 /** - * struct ocs_hcu_dma_list - An entry in an OCS DMA linked list. + * struct ocs_hcu_dma_entry - An entry in an OCS DMA linked list. * @src_addr: Source address of the data. * @src_len: Length of data to be fetched. * @nxt_desc: Next descriptor to fetch. @@ -597,7 +597,7 @@ int ocs_hcu_hash_init(struct ocs_hcu_hash_ctx *ctx, enum ocs_hcu_algo algo) } /** - * ocs_hcu_digest() - Perform a hashing iteration. + * ocs_hcu_hash_update() - Perform a hashing iteration. * @hcu_dev: The OCS HCU device to use. * @ctx: The OCS HCU hashing context. * @dma_list: The OCS DMA list mapping the input data to process. @@ -632,7 +632,7 @@ int ocs_hcu_hash_update(struct ocs_hcu_dev *hcu_dev, } /** - * ocs_hcu_hash_final() - Update and finalize hash computation. + * ocs_hcu_hash_finup() - Update and finalize hash computation. * @hcu_dev: The OCS HCU device to use. * @ctx: The OCS HCU hashing context. * @dma_list: The OCS DMA list mapping the input data to process.
Fixes the following W=1 kernel build warning(s): drivers/crypto/keembay/ocs-hcu.c:107: warning: expecting prototype for struct ocs_hcu_dma_list. Prototype was for struct ocs_hcu_dma_entry instead drivers/crypto/keembay/ocs-hcu.c:127: warning: expecting prototype for struct ocs_dma_list. Prototype was for struct ocs_hcu_dma_list instead drivers/crypto/keembay/ocs-hcu.c:610: warning: expecting prototype for ocs_hcu_digest(). Prototype was for ocs_hcu_hash_update() instead drivers/crypto/keembay/ocs-hcu.c:648: warning: expecting prototype for ocs_hcu_hash_final(). Prototype was for ocs_hcu_hash_finup() instead Cc: Daniele Alessandrelli <daniele.alessandrelli@intel.com> Cc: Declan Murphy <declan.murphy@intel.com> Cc: Herbert Xu <herbert@gondor.apana.org.au> Cc: "David S. Miller" <davem@davemloft.net> Cc: linux-crypto@vger.kernel.org Signed-off-by: Lee Jones <lee.jones@linaro.org> --- drivers/crypto/keembay/ocs-hcu.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- 2.25.1