| Message ID | 1410637161-4865-2-git-send-email-victor.kamensky@linaro.org |
|---|---|
| State | Accepted |
| Commit | 7a0bd49713aca3040099e1413d1cc9f08802d97a |
| Headers | show |
On Sat, Sep 13, 2014 at 12:39:21PM -0700, Victor Kamensky wrote: > Previous commits that dealt with get_user for 64bit type missed to > export proper functions, so if get_user macro with particular target/value > types are used by kernel module modpost would produce 'undefined!' error. > Solution is to export all required functions. > > Signed-off-by: Victor Kamensky <victor.kamensky@linaro.org> Patch looks good on its own, please send to the patch system. I can either apply it as a follow on patch, or I can merge it into your original patch. Which would you prefer?
On 13 September 2014 15:00, Russell King - ARM Linux <linux@arm.linux.org.uk> wrote: > On Sat, Sep 13, 2014 at 12:39:21PM -0700, Victor Kamensky wrote: >> Previous commits that dealt with get_user for 64bit type missed to >> export proper functions, so if get_user macro with particular target/value >> types are used by kernel module modpost would produce 'undefined!' error. >> Solution is to export all required functions. >> >> Signed-off-by: Victor Kamensky <victor.kamensky@linaro.org> > > Patch looks good on its own, please send to the patch system. Submitted as http://www.arm.linux.org.uk/developer/patches/viewpatch.php?id=8151/1 > I can either apply it as a follow on patch, or I can merge it into your > original patch. Which would you prefer? Either way is fine with me, whatever easier for you. Thanks, Victor > -- > FTTC broadband for 0.8mile line: currently at 9.5Mbps down 400kbps up > according to speedtest.net.
diff --git a/arch/arm/kernel/armksyms.c b/arch/arm/kernel/armksyms.c index f7b450f..a88671c 100644 --- a/arch/arm/kernel/armksyms.c +++ b/arch/arm/kernel/armksyms.c @@ -98,6 +98,14 @@ EXPORT_SYMBOL(__clear_user); EXPORT_SYMBOL(__get_user_1); EXPORT_SYMBOL(__get_user_2); EXPORT_SYMBOL(__get_user_4); +EXPORT_SYMBOL(__get_user_8); + +#ifdef __ARMEB__ +EXPORT_SYMBOL(__get_user_64t_1); +EXPORT_SYMBOL(__get_user_64t_2); +EXPORT_SYMBOL(__get_user_64t_4); +EXPORT_SYMBOL(__get_user_32t_8); +#endif EXPORT_SYMBOL(__put_user_1); EXPORT_SYMBOL(__put_user_2);
Previous commits that dealt with get_user for 64bit type missed to export proper functions, so if get_user macro with particular target/value types are used by kernel module modpost would produce 'undefined!' error. Solution is to export all required functions. Signed-off-by: Victor Kamensky <victor.kamensky@linaro.org> --- arch/arm/kernel/armksyms.c | 8 ++++++++ 1 file changed, 8 insertions(+)