| Message ID | 20210127104617.1173-5-nikita.shubin@maquefel.me |
|---|---|
| State | Superseded |
| Headers | show |
| Series | gpiolib: warning on gpiochip->to_irq defined | expand |
Hi! On Wed, 2021-01-27 at 13:46 +0300, Nikita Shubin wrote: > As ->to_irq is redefined in gpiochip_add_irqchip, having it defined > in > driver is useless, so let's drop it. > > Signed-off-by: Nikita Shubin <nikita.shubin@maquefel.me> Reviewed-by: Alexander Sverdlin <alexander.sverdlin@gmail.com> > --- > drivers/gpio/gpio-ep93xx.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/drivers/gpio/gpio-ep93xx.c b/drivers/gpio/gpio-ep93xx.c > index 9c3d049e5af7..dee19372ebbd 100644 > --- a/drivers/gpio/gpio-ep93xx.c > +++ b/drivers/gpio/gpio-ep93xx.c > @@ -337,11 +337,6 @@ static int ep93xx_gpio_set_config(struct > gpio_chip *gc, unsigned offset, > return 0; > } > > -static int ep93xx_gpio_f_to_irq(struct gpio_chip *gc, unsigned > offset) > -{ > - return EP93XX_GPIO_F_IRQ_BASE + offset; > -} > - > static void ep93xx_init_irq_chips(struct ep93xx_gpio *epg) > { > int i; > @@ -429,7 +424,6 @@ static int ep93xx_gpio_add_bank(struct gpio_chip > *gc, > } > girq->default_type = IRQ_TYPE_NONE; > girq->handler = handle_level_irq; > - gc->to_irq = ep93xx_gpio_f_to_irq; > girq->first = EP93XX_GPIO_F_IRQ_BASE; > } >
diff --git a/drivers/gpio/gpio-ep93xx.c b/drivers/gpio/gpio-ep93xx.c index 9c3d049e5af7..dee19372ebbd 100644 --- a/drivers/gpio/gpio-ep93xx.c +++ b/drivers/gpio/gpio-ep93xx.c @@ -337,11 +337,6 @@ static int ep93xx_gpio_set_config(struct gpio_chip *gc, unsigned offset, return 0; } -static int ep93xx_gpio_f_to_irq(struct gpio_chip *gc, unsigned offset) -{ - return EP93XX_GPIO_F_IRQ_BASE + offset; -} - static void ep93xx_init_irq_chips(struct ep93xx_gpio *epg) { int i; @@ -429,7 +424,6 @@ static int ep93xx_gpio_add_bank(struct gpio_chip *gc, } girq->default_type = IRQ_TYPE_NONE; girq->handler = handle_level_irq; - gc->to_irq = ep93xx_gpio_f_to_irq; girq->first = EP93XX_GPIO_F_IRQ_BASE; }
As ->to_irq is redefined in gpiochip_add_irqchip, having it defined in driver is useless, so let's drop it. Signed-off-by: Nikita Shubin <nikita.shubin@maquefel.me> --- drivers/gpio/gpio-ep93xx.c | 6 ------ 1 file changed, 6 deletions(-)