diff mbox series

crypto: octeontx2 - fix signedness bug in cptvf_register_interrupts()

Message ID YBD5Z11GeYlJGuTh@mwanda
State Accepted
Commit b33fa5ff8190befed1eb0ac4783e15adfa7f7135
Headers show
Series crypto: octeontx2 - fix signedness bug in cptvf_register_interrupts() | expand

Commit Message

Dan Carpenter Jan. 27, 2021, 5:25 a.m. UTC
The "num_vec" has to be signed for the error handling to work.

Fixes: 19d8e8c7be15 ("crypto: octeontx2 - add virtual function driver support")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
 drivers/crypto/marvell/octeontx2/otx2_cptvf_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Herbert Xu Feb. 5, 2021, 3:38 a.m. UTC | #1
On Wed, Jan 27, 2021 at 08:25:59AM +0300, Dan Carpenter wrote:
> The "num_vec" has to be signed for the error handling to work.

> 

> Fixes: 19d8e8c7be15 ("crypto: octeontx2 - add virtual function driver support")

> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

> ---

>  drivers/crypto/marvell/octeontx2/otx2_cptvf_main.c | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)


Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
diff mbox series

Patch

diff --git a/drivers/crypto/marvell/octeontx2/otx2_cptvf_main.c b/drivers/crypto/marvell/octeontx2/otx2_cptvf_main.c
index 9663be38ee40..47f378731024 100644
--- a/drivers/crypto/marvell/octeontx2/otx2_cptvf_main.c
+++ b/drivers/crypto/marvell/octeontx2/otx2_cptvf_main.c
@@ -34,7 +34,7 @@  static void cptvf_disable_pfvf_mbox_intrs(struct otx2_cptvf_dev *cptvf)
 static int cptvf_register_interrupts(struct otx2_cptvf_dev *cptvf)
 {
 	int ret, irq;
-	u32 num_vec;
+	int num_vec;
 
 	num_vec = pci_msix_vec_count(cptvf->pdev);
 	if (num_vec <= 0)